Closed Bug 1260091 Opened 4 years ago Closed 4 years ago

Move using SendBidiKeyboardNotify to WidgetUtils

Categories

(Core :: Widget, defect)

Unspecified
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 --- affected
firefox49 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

When keyboard layout is changed, we send bidi keyboard information to content process on Windows and OSX (Linux is bug 1033483).  It should be shared at WidgetUtils.
Blocks: 1033483
For e10s, we send Bidi keyboard information to content process.  We should add utility method to share it for all platforms.

Review commit: https://reviewboard.mozilla.org/r/52696/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52696/
Attachment #8752662 - Flags: review?(masayuki)
Comment on attachment 8752662 [details]
MozReview Request: Bug 1260091 - Move using SendBidiKeyboardNotify to WidgetUtils. r?masayuki

https://reviewboard.mozilla.org/r/52696/#review49646

::: widget/WidgetUtils.cpp:11
(Diff revision 1)
> +#include "nsTArray.h"
> +#include "nsContentUtils.h"
> +#include "nsIBidiKeyboard.h"

nit: Could you move nsTArray.h to next of nsIBidiKeyboard.h? Then, the order becomes from a to z.

::: widget/WidgetUtils.cpp:131
(Diff revision 1)
> +  nsTArray<mozilla::dom::ContentParent*> children;
> +  mozilla::dom::ContentParent::GetAll(children);

I think that you don't need |mozilla::| here.
Attachment #8752662 - Flags: review?(masayuki) → review+
https://hg.mozilla.org/mozilla-central/rev/4367dd6106da
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.