1260091 - Move using SendBidiKeyboardNotify to WidgetUtils

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Makoto Kato [:m_kato]]

When keyboard layout is changed, we send bidi keyboard information to content process on Windows and OSX (Linux is bug 1033483).  It should be shared at WidgetUtils.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: MozReview Request: Bug 1260091 - Move using SendBidiKeyboardNotify to WidgetUtils. r?masayuki

For e10s, we send Bidi keyboard information to content process.  We should add utility method to share it for all platforms.

Review commit: https://reviewboard.mozilla.org/r/52696/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52696/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8752662 [details]
MozReview Request: Bug 1260091 - Move using SendBidiKeyboardNotify to WidgetUtils. r?masayuki

https://reviewboard.mozilla.org/r/52696/#review49646

::: widget/WidgetUtils.cpp:11
(Diff revision 1)
> +#include "nsTArray.h"
> +#include "nsContentUtils.h"
> +#include "nsIBidiKeyboard.h"

nit: Could you move nsTArray.h to next of nsIBidiKeyboard.h? Then, the order becomes from a to z.

::: widget/WidgetUtils.cpp:131
(Diff revision 1)
> +  nsTArray<mozilla::dom::ContentParent*> children;
> +  mozilla::dom::ContentParent::GetAll(children);

I think that you don't need |mozilla::| here.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4367dd6106da

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4367dd6106da