Closed Bug 1260104 Opened 4 years ago Closed 4 years ago

Fix make source-package regressions introduced by pythonification of the configure scripts

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: till, Assigned: till)

Details

Attachments

(1 file)

The recent build system changes have regressed make source-package. Luckily, the fixes are straight-forward.
Comment on attachment 8735420 [details] [diff] [review]
Fix make source-package regressions introduced by phytonification of the configure scripts

Review of attachment 8735420 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks so much for this! I've been procrastinating on diving in to estimate the damage. I'm glad it was this minimal. So far.

It doesn't help that I no longer understand why my own local builds act wonky. ( cd ../js/src; autoconf-2.13 ); ../js/src/configure ...; make doesn't always seem to work for me anymore after updating, but I haven't bothered tracking down why.
Attachment #8735420 - Flags: review?(sphink) → review+
I have to admit that "phytonification" sounded way cooler. Sounded like we converted it over to plant-based photons or something.
Summary: Fix make source-package regressions introduced by phytonification of the configure scripts → Fix make source-package regressions introduced by pythonification of the configure scripts
https://hg.mozilla.org/integration/mozilla-inbound/rev/d51e76f5d0b818c834768b631687e22199421517
Bug 1260104 - Fix make source-package regressions introduced by phytonification of the configure scripts. r=sfink
The patch in this bug is NPOTB. It only touched a script for building standalone spidermonkey releases for embedding, which is never executed during any integration builds.

I can't speak for the other set of patches, the Promise stuff or whatever it is.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9c55912a063f04b683d23fb8961e8e7ca8a3529
Bug 1260104 - Fix make source-package regressions introduced by phytonification of the configure scripts. r=sfink
(In reply to Steve Fink [:sfink] [:s:] from comment #7)
> The patch in this bug is NPOTB. It only touched a script for building
> standalone spidermonkey releases for embedding, which is never executed
> during any integration builds.
> 
> I can't speak for the other set of patches, the Promise stuff or whatever it
> is.

... except SM(p), where "p" stand for "package".
(In reply to :Ms2ger from comment #9)
> (In reply to Steve Fink [:sfink] [:s:] from comment #7)
> > The patch in this bug is NPOTB. It only touched a script for building
> > standalone spidermonkey releases for embedding, which is never executed
> > during any integration builds.
> > 
> > I can't speak for the other set of patches, the Promise stuff or whatever it
> > is.
> 
> ... except SM(p), where "p" stand for "package".

SM(pkg) is the packaging build, which did not exist when I wrote that comment. SM(p) is p for "plain", and it does not execute the make-source-package stuff.
https://hg.mozilla.org/mozilla-central/rev/e9c55912a063
https://hg.mozilla.org/mozilla-central/rev/7c7f4445cfeb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Flags: needinfo?(till)
You need to log in before you can comment on or make changes to this bug.