Closed
Bug 1260113
Opened 8 years ago
Closed 8 years ago
Fix remaining issues with zombification of tabs that are playing audio
Categories
(Firefox for Android Graveyard :: Audio/Video, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: JanH, Assigned: JanH)
References
Details
Attachments
(2 files)
Bug 1253278 prevented tabs that are playing audio from getting zombified through the LRU mechanism, however there are two remaining issues: 1. When receiving a memory pressure event (memory pressure level increases to a value >= 3, I think), we zombify *all* background tabs, so a tab playing audio could still get shut down through that mechanism. 2. When a tab playing audio is zombified, the audio playing indicator isn't updated.
Assignee | ||
Comment 1•8 years ago
|
||
When a tab is zombified, its original tab object is destroyed and replaced by a new copy set for delay loading. This stops audio playback, but doesn't invoke the normal DOMAudioPlaybackStopped event. Because of this, we continue displaying the audio playback indicator in the tabs tray after a zombification, even though the audio itself has stopped. With this patch, the zombification routine now notifies the UI to stop showing the audio playback indicator if neccessary. Review commit: https://reviewboard.mozilla.org/r/42795/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42795/
Attachment #8735460 -
Flags: review?(margaret.leibovic)
Attachment #8735461 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 2•8 years ago
|
||
Bug 1253278 added support for not zombifying least recently used tabs if they were playing audio. This patch extends this behaviour to also cover the case where we want to zombify *all* background tabs under memory-pressure. Therefore, a tab which is currently playing audio should now never get zombified, which also means that the issue about the audio playing indicator fixed in part 1 is now sidestepped. Review commit: https://reviewboard.mozilla.org/r/42797/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42797/
Comment 3•8 years ago
|
||
Comment on attachment 8735460 [details] MozReview Request: Bug 1260113 - Part 1 - Inform the Java UI to stop displaying the audio playback icon for zombified tabs. r=margaret https://reviewboard.mozilla.org/r/42795/#review39295 Nice catch.
Attachment #8735460 -
Flags: review?(margaret.leibovic) → review+
Updated•8 years ago
|
Attachment #8735461 -
Flags: review?(margaret.leibovic) → review+
Comment 4•8 years ago
|
||
Comment on attachment 8735461 [details] MozReview Request: Bug 1260113 - Part 2 - Don't zombify tabs playing audio even under memory pressure. r=margaret https://reviewboard.mozilla.org/r/42797/#review39297
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c32c5247cd2
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/e47ddbd75bb0 https://hg.mozilla.org/integration/fx-team/rev/d6acac6649a3
Keywords: checkin-needed
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e47ddbd75bb0 https://hg.mozilla.org/mozilla-central/rev/d6acac6649a3
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•