Closed Bug 1260160 Opened 4 years ago Closed 4 years ago

Refactor browser_dbg_auto-pretty-print-02.js and browser_dbg_search-sources-01.js to use Task.spawn

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: jlast, Assigned: jlast)

Details

Attachments

(1 file, 2 obsolete files)

Cleans up a couple tests w/ the new Task.spawn API
browser_dbg_auto-pretty-print-02.js
browser_dbg_search-sources-01.js
Attached patch tests.1.patch (obsolete) — Splinter Review
Attachment #8735494 - Flags: review?(jlong)
Comment on attachment 8735494 [details] [diff] [review]
tests.1.patch

Review of attachment 8735494 [details] [diff] [review]:
-----------------------------------------------------------------

I only see browser_dbg_auto-pretty-print-02.js here?

Make sure to assign yourself to this bug.
Attachment #8735494 - Flags: review?(jlong) → review+
Assignee: nobody → jlaster
Attached patch tests.2.patch (obsolete) — Splinter Review
Attachment #8735566 - Flags: review?(jlong)
Attached patch tests.2.patchSplinter Review
accidentally submitted without making the first patch obsolete
Attachment #8735494 - Attachment is obsolete: true
Attachment #8735566 - Attachment is obsolete: true
Attachment #8735566 - Flags: review?(jlong)
Attachment #8735567 - Flags: review?(jlong)
Keywords: checkin-needed
Accidentally added the checkin needed, but I believe it's now removed.
Keywords: checkin-needed
This is cleanup, so I'm assigning P3 to this.
Priority: -- → P3
jlongster mind taking a second look, now that the other test is attached.
Flags: needinfo?(jlong)
Comment on attachment 8735567 [details] [diff] [review]
tests.2.patch

Review of attachment 8735567 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!
Attachment #8735567 - Flags: review?(jlong) → review+
Flags: needinfo?(jlong)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8a8cd8d35d01
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.