Closed
Bug 1260160
Opened 8 years ago
Closed 8 years ago
Refactor browser_dbg_auto-pretty-print-02.js and browser_dbg_search-sources-01.js to use Task.spawn
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
Details
Attachments
(1 file, 2 obsolete files)
20.73 KB,
patch
|
jlong
:
review+
|
Details | Diff | Splinter Review |
Cleans up a couple tests w/ the new Task.spawn API browser_dbg_auto-pretty-print-02.js browser_dbg_search-sources-01.js
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8735494 -
Flags: review?(jlong)
Comment 2•8 years ago
|
||
Comment on attachment 8735494 [details] [diff] [review] tests.1.patch Review of attachment 8735494 [details] [diff] [review]: ----------------------------------------------------------------- I only see browser_dbg_auto-pretty-print-02.js here? Make sure to assign yourself to this bug.
Attachment #8735494 -
Flags: review?(jlong) → review+
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jlaster
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8735566 -
Flags: review?(jlong)
Assignee | ||
Comment 4•8 years ago
|
||
accidentally submitted without making the first patch obsolete
Attachment #8735494 -
Attachment is obsolete: true
Attachment #8735566 -
Attachment is obsolete: true
Attachment #8735566 -
Flags: review?(jlong)
Attachment #8735567 -
Flags: review?(jlong)
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•8 years ago
|
||
Accidentally added the checkin needed, but I believe it's now removed.
Keywords: checkin-needed
Assignee | ||
Comment 7•8 years ago
|
||
jlongster mind taking a second look, now that the other test is attached.
Flags: needinfo?(jlong)
Comment 8•8 years ago
|
||
Comment on attachment 8735567 [details] [diff] [review] tests.2.patch Review of attachment 8735567 [details] [diff] [review]: ----------------------------------------------------------------- Looks great!
Attachment #8735567 -
Flags: review?(jlong) → review+
Updated•8 years ago
|
Flags: needinfo?(jlong)
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 9•8 years ago
|
||
bugherder landing |
https://hg.mozilla.org/integration/fx-team/rev/8a8cd8d35d01
Keywords: checkin-needed
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8a8cd8d35d01
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•