Closed Bug 1260199 Opened 4 years ago Closed 4 years ago

Intermittent e10s browser_bookmark_titles.js | Uncaught exception - at :0 - Error: operation not possible on dead CPOW

Categories

(Firefox :: Bookmarks & History, defect, P5)

defect

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
e10s + ---
firefox49 --- wontfix
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: philor, Assigned: mrbkap)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Blocks: e10s-tests
tracking-e10s: --- → +
Intermittent e10s test failure
Priority: -- → P5
One of our more frequent dead CPOW failures.

TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_titles.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/general/browser_bookmark_titles.js:60 - Error: operation not possible on dead CPOW
Stack trace:
    @chrome://mochitests/content/browser/browser/base/content/test/general/browser_bookmark_titles.js:60:5
    Tester_execTest@chrome://mochikit/content/browser-test.js:784:9
    Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:704:7
    SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:743:59
    Tester_execTest@chrome://mochikit/content/browser-test.js:784:9
    Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:704:7
    SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:743:59

https://dxr.mozilla.org/mozilla-central/source/browser/base/content/test/general/browser_bookmark_titles.js#60
> is(content.document.documentURI.substring(0, 14), 'about:neterror',

Blake, looks like you were the last person to try to remove CPOW usage from this test. Would you be willing to take a crack at this? Otherwise, maybe a good mentored bug for Kevin?
Flags: needinfo?(mrbkap)
This is now the third attempt to root the CPOWs out of this test.
Assignee: nobody → mrbkap
Flags: needinfo?(mrbkap)
Comment on attachment 8791000 [details]
Bug 1260199 - Remove yet another use of CPOWs in this test.

https://reviewboard.mozilla.org/r/78570/#review77286

A quick inspection, and I can't find any more CPOW usage in this test. Nice job!

::: browser/base/content/test/general/browser_bookmark_titles.js:60
(Diff revision 1)
> +    yield ContentTask.spawn(browser, null, function() {
> -    is(content.document.documentURI.substring(0, 14), 'about:neterror',
> +      is(content.document.documentURI.substring(0, 14), 'about:neterror',
> -        "Offline mode successfully simulated network outage.");
> +          "Offline mode successfully simulated network outage.");
> +    });

Alternatively, you can access this via browser.documentURI, but I think this is probably fine.
Attachment #8791000 - Flags: review?(mconley) → review+
Pushed by mrbkap@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b3e87b91108
Remove yet another use of CPOWs in this test. r=mconley
https://hg.mozilla.org/mozilla-central/rev/3b3e87b91108
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.