Closed Bug 1260272 Opened 4 years ago Closed 2 years ago

Add a jsapi-test that creates multiple JSRuntimes in different threads

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED WONTFIX

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(2 files)

In response to a question on dev.tech.js-engine today.

We already have code for creating a second JSRuntime on a thread in shell/js.cpp, but it's not the simplest possible straight-line code. I dunno, seems like something we might as well smoke-test.
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
(The fork-join code is stolen from testThreadingExclusiveData.cpp.)
Attachment #8735613 - Flags: review?(terrence)
Comment on attachment 8735612 [details] [diff] [review]
Part 1: Whitespace style nits in jsapi-tests/tests.h

Review of attachment 8735612 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, those have always bugged me.
Attachment #8735612 - Flags: review?(terrence) → review+
Attachment #8735613 - Flags: review?(terrence) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e095aa245ac330e3978bd169f27ccf23fd30020
Bug 1260272 - Part 1: Whitespace style nits in jsapi-tests/tests.h. r=terrence.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9dacf02bb0ef6f8adde5f4085b9c3c669fdb2f60
Bug 1260272 - Part 2: Add a test that JS_NewRuntime works on threads and multiple threads can run code, racing freely. r=terrence.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Flags: needinfo?(jorendorff)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.