If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[RTL][Eyedropper] prefix character "#" of color value moves to position start or end

RESOLVED FIXED in Firefox 50

Status

()

Firefox
Developer Tools: Inspector
P2
normal
RESOLVED FIXED
2 years ago
11 months ago

People

(Reporter: magicp, Assigned: Kwan)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 50
Points:
---

Firefox Tracking Flags

(firefox48 affected, firefox50 fixed)

Details

(Whiteboard: [btpp-fix-later])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Created attachment 8735631 [details]
move prefix character position of color value in RTL locales.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160328030215

Steps to reproduce:

1. Start RTL locales Nightly (e.g. Arabic)
2. Go to about:home
3. Open DevTools > Eyedropper
4. Move eyedropper on the page


Actual results:

prefix character "#" of color value moves to position start or end by color value.


Expected results:

prefix character position does not move.
(Reporter)

Updated

2 years ago
Has STR: --- → yes
status-firefox48: --- → affected
Component: Untriaged → Developer Tools: Inspector
OS: Unspecified → All
Hardware: Unspecified → All
Summary: [RTL] prefix character "#" of color value moves to position start or end → [RTL][Eyedropper] prefix character "#" of color value moves to position start or end
Blocks: 1216762
Triaging (filter on CLIMBING SHOES).
Priority: -- → P2
Whiteboard: [btpp-fix-later]
(Assignee)

Updated

a year ago
Assignee: nobody → moz-ian
Status: NEW → ASSIGNED
(Assignee)

Comment 2

a year ago
Created attachment 8767505 [details]
Bug 1260297 - Force LTR direction for the eydropper color value so the # character doesn't move depending on colour in RTL locales.

Review commit: https://reviewboard.mozilla.org/r/61972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61972/
Attachment #8767505 - Flags: review?(jryans)
Comment on attachment 8767505 [details]
Bug 1260297 - Force LTR direction for the eydropper color value so the # character doesn't move depending on colour in RTL locales.

https://reviewboard.mozilla.org/r/61972/#review59228

Seems reasonable to me, thanks for taking a look!
Attachment #8767505 - Flags: review?(jryans) → review+
(Assignee)

Comment 4

a year ago
Thanks for the review jryans.

Wouldn't have merited a try run on it's own, but it got a ride-along with bug 1171614:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=99ca357f2ae3
Keywords: checkin-needed
Note that I'm deleting the eyedropper in bug 1262439 and replacing it with a new implementation (for the devtools.html project, in order to remove XUL). So that means this will need to be fixed again soon, after I land my change, unfortunately.
See Also: → bug 1262439
Actually, since the fix is essentially 1 line (direction: ltr;), I might add it to bug 1262439 so it's already fixed in the new implementation too.

Comment 7

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/263be4d56ba6
Force LTR direction for the eydropper color value so the # character doesn't move depending on colour in RTL locales. r=jryans
Keywords: checkin-needed

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/263be4d56ba6
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50

Comment 9

11 months ago
I have reproduced this bug with Beta 48.0b1 (Arabic) on Windows 7 , 64 Bit !

This bug's fix is verified with latest Beta 

This bug's fix is verified with latest Beta(Arabic)

Built Id   :  20161010144024 
User Agent :  Mozilla/5.0 (WindowsNT 6.1; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
[bugday-20161012]
You need to log in before you can comment on or make changes to this bug.