Closed
Bug 1260297
Opened 8 years ago
Closed 8 years ago
[RTL][Eyedropper] prefix character "#" of color value moves to position start or end
Categories
(DevTools :: Inspector, defect, P2)
DevTools
Inspector
Tracking
(firefox48 affected, firefox50 fixed)
RESOLVED
FIXED
Firefox 50
People
(Reporter: magicp.jp, Assigned: Kwan)
References
(Blocks 1 open bug)
Details
(Whiteboard: [btpp-fix-later])
Attachments
(2 files)
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0 Build ID: 20160328030215 Steps to reproduce: 1. Start RTL locales Nightly (e.g. Arabic) 2. Go to about:home 3. Open DevTools > Eyedropper 4. Move eyedropper on the page Actual results: prefix character "#" of color value moves to position start or end by color value. Expected results: prefix character position does not move.
Has STR: --- → yes
status-firefox48:
--- → affected
Component: Untriaged → Developer Tools: Inspector
OS: Unspecified → All
Hardware: Unspecified → All
Summary: [RTL] prefix character "#" of color value moves to position start or end → [RTL][Eyedropper] prefix character "#" of color value moves to position start or end
Blocks: dt-rtl
Comment 1•8 years ago
|
||
Triaging (filter on CLIMBING SHOES).
Priority: -- → P2
Whiteboard: [btpp-fix-later]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → moz-ian
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/61972/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/61972/
Attachment #8767505 -
Flags: review?(jryans)
Comment on attachment 8767505 [details] Bug 1260297 - Force LTR direction for the eydropper color value so the # character doesn't move depending on colour in RTL locales. https://reviewboard.mozilla.org/r/61972/#review59228 Seems reasonable to me, thanks for taking a look!
Attachment #8767505 -
Flags: review?(jryans) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Thanks for the review jryans. Wouldn't have merited a try run on it's own, but it got a ride-along with bug 1171614: https://treeherder.mozilla.org/#/jobs?repo=try&revision=99ca357f2ae3
Keywords: checkin-needed
Comment 5•8 years ago
|
||
Note that I'm deleting the eyedropper in bug 1262439 and replacing it with a new implementation (for the devtools.html project, in order to remove XUL). So that means this will need to be fixed again soon, after I land my change, unfortunately.
See Also: → 1262439
Comment 6•8 years ago
|
||
Actually, since the fix is essentially 1 line (direction: ltr;), I might add it to bug 1262439 so it's already fixed in the new implementation too.
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/fx-team/rev/263be4d56ba6 Force LTR direction for the eydropper color value so the # character doesn't move depending on colour in RTL locales. r=jryans
Keywords: checkin-needed
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/263be4d56ba6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment 9•8 years ago
|
||
I have reproduced this bug with Beta 48.0b1 (Arabic) on Windows 7 , 64 Bit ! This bug's fix is verified with latest Beta This bug's fix is verified with latest Beta(Arabic) Built Id : 20161010144024 User Agent : Mozilla/5.0 (WindowsNT 6.1; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0 [bugday-20161012]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•