1260325 - Utility Tray doesn't show up anymore

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[[:fabrice] Fabrice Desré]

This is on current Kanikani and the gaia changes from bug 1257935

The utility tray doesn't show up, and we have a bunch of errors like:
E/GeckoConsole(30021): [JavaScript Error: "ReferenceError: UtilityTray is not defined" {file: "chrome://gaia/content/system/js/rocketbar.js" line: 555}]

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1260325-ut-kanikani > mozilla-b2g:kanikani

Comment 2

[Alberto Pastor [:albertopq]]

Comment on attachment 8735790 [details] [review]
[gaia] albertopq:1260325-ut-kanikani > mozilla-b2g:kanikani

This is failing because some modules loaded before the utility tray are crashing (because of system messages). Ben, what do you think about loading a SystemMessages module that keeps the API but implement it internally using other technologies (Broadcast channel)?

This placeholder fixes both statusbar and utilityTray.

Comment 3

[Ben Francis [:benfrancis]]

Comment on attachment 8735790 [details] [review]
[gaia] albertopq:1260325-ut-kanikani > mozilla-b2g:kanikani

r+ if this unblocks the utility tray from working.

I'm not opposed to (reverse?) polyfilling our legacy APIs if that's the quickest strategy to get things working again, before refactoring further to remove those APIs completely. But is it even possible to replace system messages with the Broadcast Channel API if those system messages originate in Gecko/XPCOM?

We need to think about alternative solutions for all the use cases of the System Message API in the system app, I filed bug 1260444 to start looking into that.

Comment 4

[Alberto Pastor [:albertopq]]

Lets merge this in the meanwhile and fix the system messages issue in bug 1260444. Thanks!

kanikani: https://github.com/mozilla-b2g/gaia/commit/43a2c3d3db6583492fda201b61ce325681c06c01