Closed Bug 1260325 Opened 4 years ago Closed 4 years ago
Utility Tray doesn't show up anymore
46 bytes, text/x-github-pull-request
|Details | Review|
Assignee: nobody → apastor
Comment on attachment 8735790 [details] [review] [gaia] albertopq:1260325-ut-kanikani > mozilla-b2g:kanikani This is failing because some modules loaded before the utility tray are crashing (because of system messages). Ben, what do you think about loading a SystemMessages module that keeps the API but implement it internally using other technologies (Broadcast channel)? This placeholder fixes both statusbar and utilityTray.
Attachment #8735790 - Flags: review?(bfrancis)
Comment on attachment 8735790 [details] [review] [gaia] albertopq:1260325-ut-kanikani > mozilla-b2g:kanikani r+ if this unblocks the utility tray from working. I'm not opposed to (reverse?) polyfilling our legacy APIs if that's the quickest strategy to get things working again, before refactoring further to remove those APIs completely. But is it even possible to replace system messages with the Broadcast Channel API if those system messages originate in Gecko/XPCOM? We need to think about alternative solutions for all the use cases of the System Message API in the system app, I filed bug 1260444 to start looking into that.
Attachment #8735790 - Flags: review?(bfrancis) → review+
Lets merge this in the meanwhile and fix the system messages issue in bug 1260444. Thanks! kanikani: https://github.com/mozilla-b2g/gaia/commit/43a2c3d3db6583492fda201b61ce325681c06c01
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Component: Gaia::System → Gaia::System::Status bar, Utility tray, Notification
You need to log in before you can comment on or make changes to this bug.