1260327 - about:buildconfig doesn't contain all configure flags anymore

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

We use ac_configure_args to fill about:buildconfig. We're currently getting ac_configure_args as an AC_SUBST from old-configure, which means it only contains options we pass down to old-configure, which, as we're moving options from old-configure to moz.configure, is less and less. So, in practice, now, some options don't make it to ac_configure_args.

But, I'm also willing to go a little further, now that we have the smarts to allow it, at least for the options that are defined in moz.configure: It's not really interesting to show, in about:buildconfig, options that were explicitly given, but that match the defaults: that's just noise. We can now also eliminate them (for example, it's not interesting that --enable-url-classifier makes it to about:buildconfig just because it was explicitly on configure's command line (or in the mozconfig), because it's the default).

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1260327 - Remove the --recheck option of config.status. r?chmanchester

With mozconfigs injecting options, it never really worked as intended.

Review commit: https://reviewboard.mozilla.org/r/46029/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46029/

Comment 2

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1260327 - Expose a MOZ_CONFIGURE_OPTIONS variable containing configure options. r?chmanchester

Review commit: https://reviewboard.mozilla.org/r/46031/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46031/

Comment 3

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1260327 - Switch buildconfig.html to using MOZ_CONFIGURE_OPTIONS. r?chmanchester

Review commit: https://reviewboard.mozilla.org/r/46033/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46033/

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8740825 [details]
MozReview Request: Bug 1260327 - Expose a MOZ_CONFIGURE_OPTIONS variable containing configure options. r?chmanchester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46031/diff/1-2/

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8740826 [details]
MozReview Request: Bug 1260327 - Switch buildconfig.html to using MOZ_CONFIGURE_OPTIONS. r?chmanchester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46033/diff/1-2/

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8740824 [details]
MozReview Request: Bug 1260327 - Remove the --recheck option of config.status. r?chmanchester

https://reviewboard.mozilla.org/r/46029/#review43003

Comment 7

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8740825 [details]
MozReview Request: Bug 1260327 - Expose a MOZ_CONFIGURE_OPTIONS variable containing configure options. r?chmanchester

https://reviewboard.mozilla.org/r/46031/#review43011

Comment 8

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8740826 [details]
MozReview Request: Bug 1260327 - Switch buildconfig.html to using MOZ_CONFIGURE_OPTIONS. r?chmanchester

https://reviewboard.mozilla.org/r/46033/#review43013

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5864ce92b533
https://hg.mozilla.org/integration/mozilla-inbound/rev/450647e36329
https://hg.mozilla.org/integration/mozilla-inbound/rev/993766c094cf

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5864ce92b533
https://hg.mozilla.org/mozilla-central/rev/450647e36329
https://hg.mozilla.org/mozilla-central/rev/993766c094cf