Closed Bug 1260327 Opened 4 years ago Closed 4 years ago

about:buildconfig doesn't contain all configure flags anymore

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

We use ac_configure_args to fill about:buildconfig. We're currently getting ac_configure_args as an AC_SUBST from old-configure, which means it only contains options we pass down to old-configure, which, as we're moving options from old-configure to moz.configure, is less and less. So, in practice, now, some options don't make it to ac_configure_args.

But, I'm also willing to go a little further, now that we have the smarts to allow it, at least for the options that are defined in moz.configure: It's not really interesting to show, in about:buildconfig, options that were explicitly given, but that match the defaults: that's just noise. We can now also eliminate them (for example, it's not interesting that --enable-url-classifier makes it to about:buildconfig just because it was explicitly on configure's command line (or in the mozconfig), because it's the default).
Depends on: 1256571
Assignee: nobody → mh+mozilla
With mozconfigs injecting options, it never really worked as intended.

Review commit: https://reviewboard.mozilla.org/r/46029/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46029/
Attachment #8740824 - Flags: review?(cmanchester)
Attachment #8740825 - Flags: review?(cmanchester)
Attachment #8740826 - Flags: review?(cmanchester)
Comment on attachment 8740825 [details]
MozReview Request: Bug 1260327 - Expose a MOZ_CONFIGURE_OPTIONS variable containing configure options. r?chmanchester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46031/diff/1-2/
Comment on attachment 8740826 [details]
MozReview Request: Bug 1260327 - Switch buildconfig.html to using MOZ_CONFIGURE_OPTIONS. r?chmanchester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46033/diff/1-2/
Summary: ac_configure_args doesn't contain all configure flags anymore → about:buildconfig doesn't contain all configure flags anymore
Attachment #8740824 - Flags: review?(cmanchester) → review+
Comment on attachment 8740824 [details]
MozReview Request: Bug 1260327 - Remove the --recheck option of config.status. r?chmanchester

https://reviewboard.mozilla.org/r/46029/#review43003
Comment on attachment 8740825 [details]
MozReview Request: Bug 1260327 - Expose a MOZ_CONFIGURE_OPTIONS variable containing configure options. r?chmanchester

https://reviewboard.mozilla.org/r/46031/#review43011
Attachment #8740825 - Flags: review?(cmanchester) → review+
Attachment #8740826 - Flags: review?(cmanchester) → review+
Comment on attachment 8740826 [details]
MozReview Request: Bug 1260327 - Switch buildconfig.html to using MOZ_CONFIGURE_OPTIONS. r?chmanchester

https://reviewboard.mozilla.org/r/46033/#review43013
Depends on: 1265063
Product: Core → Firefox Build System
See Also: → 1501824
You need to log in before you can comment on or make changes to this bug.