1260329 - Properly escape the frameTable when running |dmd.py --clamp-contents|

Status: RESOLVED FIXED

(Core :: DMD, defect)

Description

[Nicholas Nethercote [inactive]]

I was getting test failures on my Windows machine because |dmd.py
--clamp-contents| was not properly escaping backslashes in file paths when it
rewrote the JSON file.

I don't know why this wasn't causing problems on automation.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Properly escape the frameTable when running |dmd.py --clamp-contents|

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 8735674 [details] [diff] [review]
Properly escape the frameTable when running |dmd.py --clamp-contents|

Review of attachment 8735674 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. I think I've seen something like this before.

Comment 3

[Andrew McCreight [:mccr8]]

Bug 1091262 is what I was thinking of, but I'm not sure if it is the same thing or not.

Comment 4

[Nicholas Nethercote [inactive]]

(In reply to Andrew McCreight [:mccr8] from comment #3)
> Bug 1091262 is what I was thinking of, but I'm not sure if it is the same
> thing or not.

If you were running with --clamp-contents (and I figure it's a good chance you were) then it would be the same problem. Let's be optimistic and call it a dup.

Comment 6

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/35053f4c889b0c2bec7812a6614d2b3eba2f349a
Bug 1260329 - Properly escape the frameTable when running |dmd.py --clamp-contents|. r=mccr8.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/35053f4c889b