Open Bug 1260362 Opened 8 years ago Updated 2 years ago

check that yasm > 1.1 is used as ffvpx compilation is broken with yasm 1.1

Categories

(Firefox Build System :: General, defect)

x86_64
macOS
defect

Tracking

(Not tracked)

People

(Reporter: ewong, Unassigned)

References

Details

Attachments

(1 file)

Currently c-b is busted on OSX64:

/builds/slave/c-beta-osx64/build/clang/bin/clang -arch x86_64 -o oaes_lib.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DMOZ_NO_MOZALLOC -I/builds/slave/c-beta-osx64/build/mozilla/media/gmp-clearkey/0.1 -I/builds/slave/c-beta-osx64/build/objdir/x86_64/media/gmp-clearkey/0.1 -I/builds/slave/c-beta-osx64/build/mozilla/dom/media/gmp -I/builds/slave/c-beta-osx64/build/objdir/x86_64/dist/include  -I/builds/slave/c-beta-osx64/build/objdir/x86_64/dist/include/nspr -I/builds/slave/c-beta-osx64/build/objdir/x86_64/dist/include/nss       -fPIC  -include /builds/slave/c-beta-osx64/build/objdir/x86_64/mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/oaes_lib.o.pp -Qunused-arguments  -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wtype-limits -Wclass-varargs -Wsometimes-uninitialized -Wno-unused-local-typedef -gdwarf-2 -isysroot /Developer/SDKs/MacOSX10.7.sdk -std=gnu99 -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -DNO_X11 -pipe  -gdwarf-2 -O3 -fno-omit-frame-pointer   -Wno-missing-braces -Wno-pointer-to-int-cast -Wno-sign-compare -include stdio.h -include unistd.h   /builds/slave/c-beta-osx64/build/mozilla/media/gmp-clearkey/0.1/openaes/oaes_lib.c
Unified_cpp_gmp-clearkey_0.10.o
/builds/slave/c-beta-osx64/build/mozilla/media/ffvpx/libavcodec/x86/videodsp.asm:136: error: instruction expected after label
/builds/slave/c-beta-osx64/build/mozilla/media/ffvpx/libavcodec/x86/videodsp.asm:136: error: undefined symbol `vpbroadcastb.y_loop' (first use)
/builds/slave/c-beta-osx64/build/mozilla/media/ffvpx/libavcodec/x86/videodsp.asm:136: error:  (Each undefined symbol is reported only once.)
/builds/slave/c-beta-osx64/build/mozilla/media/ffvpx/libavcodec/x86/videodsp.asm:459: error: instruction expected after label
/builds/slave/c-beta-osx64/build/mozilla/media/ffvpx/libavcodec/x86/videodsp.asm:459: error: undefined symbol `vpbroadcastb.loop_y' (first use)
/builds/slave/c-beta-osx64/build/mozilla/media/ffvpx/libavcodec/x86/videodsp.asm:459: error: instruction expected after label
/builds/slave/c-beta-osx64/build/mozilla/media/ffvpx/libavcodec/x86/videodsp.asm:459: error: instruction expected after label
/builds/slave/c-beta-osx64/build/mozilla/media/ffvpx/libavcodec/x86/videodsp.asm:459: error: instruction expected after label
/builds/slave/c-beta-osx64/build/mozilla/media/ffvpx/libavcodec/x86/videodsp.asm:459: error: instruction expected after label
/builds/slave/c-beta-osx64/build/mozilla/media/ffvpx/libavcodec/x86/videodsp.asm:459: error: instruction expected after label
/builds/slave/c-beta-osx64/build/mozilla/media/ffvpx/libavcodec/x86/videodsp.asm:459: error: instruction expected after label
/builds/slave/c-beta-osx64/build/mozilla/media/ffvpx/libavcodec/x86/videodsp.asm:459: error: instruction expected after label
make[5]: *** [videodsp.o] Error 1
make[4]: *** [media/ffvpx/libavcodec/x86/target] Error 2
make[4]: *** Waiting for unfinished jobs....
Version: SeaMonkey 2.41 Branch → SeaMonkey 2.43 Branch
Ditto with comm-aurora
and comm-central.
Product: SeaMonkey → Core
Version: SeaMonkey 2.43 Branch → 43 Branch
What is the yasm version you are using?
Flags: needinfo?(ewong)
(In reply to Georg Koppen from comment #3)
> What is the yasm version you are using?

from the build log, 1.1.0.2352.
Flags: needinfo?(ewong)
That's too old. I needed to update my yasm to 1.2.0 to get rid of this error. While this is fine I think the bug is that this check does not happen in the configure script.
Blocks: 1214462
Summary: media/ffvpx/libavcodec/x86/videodsp.asm : error: undefined symbol 'vpbroadcastb.y_loop' (first use) → check that yasm > 1.1 is used as ffvpx compilation is broken with yasm 1.1
Version: 43 Branch → Trunk
FWIW: I hit this problem while cross-compiling with mingw-w64 using an older Ubuntu Precise box.
try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e589efda7104bbb06af4d30e9b13ea9a9f37b0d7

(* though I'm not exactly sure this is going to prove anything since the 
slaves could have yasm 1.2 already. *)
(In reply to Edmund Wong (:ewong) from comment #8)
> try push:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=e589efda7104bbb06af4d30e9b13ea9a9f37b0d7
> 
> (* though I'm not exactly sure this is going to prove anything since the 
> slaves could have yasm 1.2 already. *)

they have 1.3.
Comment on attachment 8739899 [details]
MozReview Request: Bug 1260362 - Check that yasm > 1.1 is used as ffvpx compilation is broken with yasm 1.1 r?glandium

https://reviewboard.mozilla.org/r/45429/#review42169

You're effectively changing the requirements for libvpx, not ffvpx. Unfortunately, ffvpx shares its check with libav-fft, which doesn't require 1.2. At this point it would be better to move both libav-fft and ffvpx checks to python configure before trying to fix the yasm version requirement.
Attachment #8739899 - Flags: review?(mh+mozilla)
bug 1257904 is filed on moving the YASM version checks to moz.configure.
Product: Core → Firefox Build System
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.