12604 - MLK: nsIFileSpec stuff

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect, P3)

Description

[Bruce Mitchener]

Looks to me like cookie_ProfileDirectory() is leaking 'spec'

MLK: 28 bytes leaked at 0x59f168
  * This memory was allocated from:
        malloc         [rtlib.o]
        __bUiLtIn_nEw  [libraptorgfx.so]
        __builtin_new  [rtlib.o]
        nsFileSpecImpl::MakeInterface(const nsFileSpec&,nsIFileSpec**)
[nsFileSpecImpl.cpp:67]
        NS_NewFileSpecWithSpec(const nsFileSpec&,nsIFileSpec**)
[nsFileSpecImpl.cpp:749]
        nsFileLocator::GetFileLocation(unsigned int,nsIFileSpec**)
[nsFileLocations.cpp:467]
        NS_LocateFileOrDirectory(unsigned int) [nsIFileLocator.h:61]
        cookie_ProfileDirectory(nsFileSpec&) [nsCookie.cpp:300]
        cookie_LoadCookies() [nsCookie.cpp:1884]
        COOKIE_ReadCookies() [nsCookie.cpp:1999]
        nsCookieService::Init() [nsCookieService.cpp:146]
        nsCookieService::nsCookieService() [nsCookieService.cpp:97]
        nsCookieService::GetCookieService(nsICookieService**)
[nsCookieService.cpp:106]
        NS_NewCookieService(nsICookieService**) [nsCookieService.cpp:91]
        nsCookieServiceFactory::CreateInstance(nsISupports*,const nsID&,void**)
[nsCookieService.cpp:223]
        nsComponentManagerImpl::CreateInstance(const nsID&,nsISupports*,const
nsID&,void**) [nsComponentManager.cpp:1398]
        nsComponentManager::CreateInstance(const nsID&,nsISupports*,const
nsID&,void**) [nsRepository.cpp:77]
        nsServiceManagerImpl::GetService(const nsID&,const
nsID&,nsISupports**,nsIShutdownListener*) [nsServiceManager.cpp:228]
        nsServiceManager::GetService(const nsID&,const
nsID&,nsISupports**,nsIShutdownListener*) [nsServiceManager.cpp:434]
        main1(int,char**) [nsAppRunner.cpp:715]
        main           [nsAppRunner.cpp:831]
        _start         [crt1.o]

Comment 1

[Stephen P. Morse]

Change to nsCookie.cpp checked in.  Also had the same error in wallet.cpp (two
places) and that change has been checked in as well.