Closed Bug 1260402 Opened 3 years ago Closed 3 years ago

Mulet build failure: cudeb test link failure

Categories

(Firefox OS Graveyard :: Runtime, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
2.6 S11 - 4/8
Tracking Status
firefox48 --- fixed

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

(Whiteboard: fixed-in-pine)

Attachments

(1 file)

0:32.80 Executing: /usr/bin/ccache c++ -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wc++14-compat -Wno-invalid-offsetof -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer -o test_resampler /home/alex/codaz/Mozilla/gecko-cinnabar/obj-mulet-dbg/media/libcubeb/tests/tmpJ7To6K.list -lpthread -Wl,-z,noexecstack -Wl,-z,text -Wl,--build-id -rdynamic -rdynamic -Wl,-rpath-link,/home/alex/codaz/Mozilla/gecko-cinnabar/obj-mulet-dbg/dist/bin -Wl,-rpath-link,/usr/local/lib ../../../xpcom/glue/libxpcomglue_s.a ../../../config/external/nspr/pr/libnspr4.so ../../../config/external/nspr/libc/libplc4.so ../../../config/external/nspr/ds/libplds4.so ../../../toolkit/library/libxul.so -ldl -lasound
 0:32.80 /home/alex/codaz/Mozilla/gecko-cinnabar/obj-mulet-dbg/media/libcubeb/tests/tmpJ7To6K.list:
 0:32.80     INPUT("test_resampler.o")
 0:32.80     INPUT("../../../mozglue/build/SSE.o")
 0:32.80     INPUT("../../../mozglue/build/dummy.o")
 0:32.80     INPUT("../../../memory/mozalloc/Unified_cpp_memory_mozalloc0.o")
 0:32.80     INPUT("../../../mozglue/misc/StackWalk.o")
 0:32.80     INPUT("../../../mozglue/misc/TimeStamp.o")
 0:32.80     INPUT("../../../mozglue/misc/TimeStamp_posix.o")
 0:32.80     INPUT("../../../mfbt/Compression.o")
 0:32.81     INPUT("../../../mfbt/Decimal.o")
 0:32.81     INPUT("../../../mfbt/Unified_cpp_mfbt0.o")
 0:32.81     INPUT("../../../memory/build/mozmemory_wrap.o")
 0:32.81     INPUT("../../../memory/build/replace_malloc.o")
 0:32.81     INPUT("../../../memory/build/jemalloc_config.o")
 0:32.81     INPUT("../../../memory/mozjemalloc/jemalloc.o")
 0:32.81     INPUT("../../../memory/fallible/fallible.o")
 0:32.81     INPUT("../src/cubeb.o")
 0:32.82     INPUT("../src/cubeb_alsa.o")
 0:32.82     INPUT("../src/cubeb_panner.o")
 0:32.82     INPUT("../../libspeex_resampler/src/resample.o")
 0:32.83     INPUT("../../libspeex_resampler/src/resample_sse.o")
 0:32.83     INPUT("../../libspeex_resampler/src/simd_detect.o")
 0:32.83 
 0:32.83 test_resampler.o: In function `test_output_only_noop()':
 0:32.84 /home/alex/codaz/Mozilla/gecko-cinnabar/media/libcubeb/tests/test_resampler.cpp:490: undefined reference to `cubeb_resampler_create'
 0:32.84 /home/alex/codaz/Mozilla/gecko-cinnabar/media/libcubeb/tests/test_resampler.cpp:497: undefined reference to `cubeb_resampler_fill'
 0:32.84 /home/alex/codaz/Mozilla/gecko-cinnabar/media/libcubeb/tests/test_resampler.cpp:501: undefined reference to `cubeb_resampler_destroy'
 0:32.84 test_resampler.o: In function `test_resampler_drain()':
 0:32.84 /home/alex/codaz/Mozilla/gecko-cinnabar/media/libcubeb/tests/test_resampler.cpp:526: undefined reference to `cubeb_resampler_create'
 0:32.84 /home/alex/codaz/Mozilla/gecko-cinnabar/media/libcubeb/tests/test_resampler.cpp:534: undefined reference to `cubeb_resampler_fill'
 0:32.84 /home/alex/codaz/Mozilla/gecko-cinnabar/media/libcubeb/tests/test_resampler.cpp:541: undefined reference to `cubeb_resampler_destroy'
 0:32.84 test_resampler.o: In function `void test_resampler_duplex<float>(unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, float)':
 0:32.85 /home/alex/codaz/Mozilla/gecko-cinnabar/media/libcubeb/tests/test_resampler.cpp:345: undefined reference to `cubeb_resampler_create'
 0:32.85 /home/alex/codaz/Mozilla/gecko-cinnabar/media/libcubeb/tests/test_resampler.cpp:347: undefined reference to `cubeb_resampler_latency'
 0:32.85 /home/alex/codaz/Mozilla/gecko-cinnabar/media/libcubeb/tests/test_resampler.cpp:382: undefined reference to `cubeb_resampler_fill'
 0:32.85 /home/alex/codaz/Mozilla/gecko-cinnabar/media/libcubeb/tests/test_resampler.cpp:404: undefined reference to `cubeb_resampler_destroy'
 0:32.86 /usr/bin/ld: test_resampler: hidden symbol `cubeb_resampler_create' isn't defined
 0:32.86 /usr/bin/ld: final link failed: Bad value
 0:32.86 collect2: error: ld returned 1 exit status
Ok, so cubeb_resampler.cpp is being built if we build with PulseAudio. Now, old-configure.in does check for MOZ_B2G existence to NOT define MOZ_PULSEAUDIO=1 on Linux platform. I guess we want to avoid Pulse only on Gonk?
Attachment #8735810 - Flags: review?(mh+mozilla)
Comment on attachment 8735810 [details]
MozReview Request: Bug 1260402 - Disable PulseAudio only on Gonk for B2G r?glandium

https://reviewboard.mozilla.org/r/42949/#review39727

::: old-configure.in:4350
(Diff revision 1)
>  dnl If using Linux, ensure that the PA library is available
>  case "$OS_TARGET" in
>  WINNT|Darwin|Android|OpenBSD)
>      ;;
>  *)
> -    if test -z "$MOZ_B2G"; then
> +    if test -z "$MOZ_B2G" -o -n "$MOZ_MULET"; then

If that test was about gonk, then it was useless in the first place: with gonk, OS_TARGET is Android.
Ok, having a look at the history. A long time ago, the test was something like |"$OS_TARGET" = "Linux" -a -z "$MOZ_B2G"|: https://hg.mozilla.org/mozilla-central/rev/6c15f3df605a#l2.172

Then it became: https://hg.mozilla.org/mozilla-central/diff/e6c2155d6e51/configure.in#l1.12 where "Android" is explicitely removed and MOZ_B2G is kept on Linux platform.
Comment on attachment 8735810 [details]
MozReview Request: Bug 1260402 - Disable PulseAudio only on Gonk for B2G r?glandium

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42949/diff/1-2/
Attachment #8735810 - Flags: review?(mh+mozilla)
Comment on attachment 8735810 [details]
MozReview Request: Bug 1260402 - Disable PulseAudio only on Gonk for B2G r?glandium

https://reviewboard.mozilla.org/r/42949/#review40283

::: old-configure.in:4345
(Diff revision 2)
>  
>  dnl ========================================================
>  dnl = Disable PulseAudio
>  dnl ========================================================
>  
>  dnl If using Linux, ensure that the PA library is available

Just say Desktop Linux here, and drop the gonk is ... mulet is ... comment.
Attachment #8735810 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8735810 [details]
MozReview Request: Bug 1260402 - Disable PulseAudio only on Gonk for B2G r?glandium

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42949/diff/2-3/
https://hg.mozilla.org/mozilla-central/rev/65a35fd405be
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S11 - 4/8
You need to log in before you can comment on or make changes to this bug.