1260417 - Some callback improvements

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: Add a comment about the compartment of CallbackObject::mCallback

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Depend on AutoEntryScript to find an appropriate JSContext CallSetup

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8735841 [details] [diff] [review]
Part a: Add a comment about the compartment of CallbackObject::mCallback

I think this should say "call a callback f(), or get its members, directly itself, this code won't call f(), or get its members, on the code's behalf".

r=me with that.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8735842 [details] [diff] [review]
Part b: Depend on AutoEntryScript to find an appropriate JSContext CallSetup

>-        // Make sure that if this is a window it has an active document, since

Might be worth saying something about how we don't want to run script in windows that have been navigated away from?

r=me

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Depend on AutoEntryScript to find an appropriate JSContext CallSetup

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8735863 [details] [diff] [review]
Part b: Depend on AutoEntryScript to find an appropriate JSContext CallSetup

r=me

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part c: Stop mentioning requests around CallSetup::mRootedCallable

Rooted used to only work when the JSContext was in a request. This has long
been rectified, so the comments referring to that constraint are confusing at
best.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8735874 [details] [diff] [review]
Part c: Stop mentioning requests around CallSetup::mRootedCallable

r=me

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0282db6a832c
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ec261488c75
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d533891bb51

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0282db6a832c
https://hg.mozilla.org/mozilla-central/rev/6ec261488c75
https://hg.mozilla.org/mozilla-central/rev/5d533891bb51