1260579 - Developer Toolbar Close button icon is wrong

Status: RESOLVED INCOMPLETE

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P2)

Description

[magicp]

Attachment: developer-toolbar-close-button.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160329030246

Steps to reproduce:

1. Start latest Nightly
2. Open Developer Toolbar (Shift+F2)


Actual results:

Developer Toolbar Close button icon is wrong. It is different from the others.


Expected results:

Developer Toolbar Close button icon should use "chrome://devtools/skin/images/close.png"

Comment 1

[Sebastian Zartner [:sebo]]

It currently uses chrome://global/skin/icons/close.png, which is conforming to other toolbars. If it's wanted to be conform to the DevTools theme, chrome://devtools/skin/images/close.svg should be used instead (which replaces the previously used chrome://devtools/skin/images/close.png).

Sebastian

Comment 2

[Itiel]

magicp, it seems as if this bug is fixed. Can you please verify?

Comment 3

[Tomer Cohen :tomer]

Attachment: Screenshot

(In reply to ItielMaN from comment #2)
> magicp, it seems as if this bug is fixed. Can you please verify?

Still reproducible with the bright and dark themes.

Comment 4

[Itiel]

Attachment: Screenshot taken from Windows 10

This screenshot was taken from Windows 10, Tomer's was taken from Linux.

Comment 5

[Firefox Bug Husbandry Bot]

Per bug 1491875, this component has been closed, and the affected code is being removed from Firefox. Closing this bug as incomplete.