Closed Bug 1260582 Opened 6 years ago Closed 10 months ago

Investigate GeckoProfile initialization in onCreate

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: mcomella, Unassigned, Mentored)

References

Details

In onStart, there is a comment explaining we don't want to init GeckoProfile too soon (presumably for disk access issues). However, in onCreate, we do the same checks.

We should either:
* move the initial checks off the main thread
* Remove the comment from onStart
* Remove the comment from onStart and push the check onto the UIThread

Profiling recommended. :)
15:21 <mcomella> rnewman: I think we init the profile in onCreate (https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#579), before we do that queue to the bg thread to prevent profile init too early (https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#1052), so I
15:21 <mcomella> don't think the comment is correct. Am I missing something?

15:31 <@rnewman> mcomella: I think checking whether we were a guest profile used to be really expensive
15:31 <@rnewman> added here: http://hg.mozilla.org/mozilla-central/rev/f900c41d821d#l1.58
15:32 <@rnewman> mcomella: but also we didn't used to do any profile stuff in onCreate: http://hg.mozilla.org/mozilla-central/file/f900c41d821d/mobile/android/base/BrowserApp.java#l519
15:33 <@rnewman> mcomella: so yes, if you've moved profile init into onCreate, then (a) that might account for our startup time regression this quarter, and (b) that comment is inaccurate :P
FYI, GeckoProfile does its expensive init in GeckoProfile.forceCreate, which is called when the GeckoView is initialized in layout.
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.