Closed Bug 1260624 Opened 8 years ago Closed 8 years ago

Move CROSS_COMPILE to moz.configure

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

      No description provided.
Note that this removes force-setting cross_compiling to yes in
old-configure, which wasn't working because every AC_TRY_COMPILE
resets it with $ac_cv_prog_cc_cross or $ac_cv_prog_cxx_cross.

Review commit: https://reviewboard.mozilla.org/r/43141/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43141/
Comment on attachment 8736145 [details]
MozReview Request: Bug 1260624 - Add support for simple comparisons of ReadOnlyNamespaces. r?ted

https://reviewboard.mozilla.org/r/43139/#review40117

::: python/mozbuild/mozbuild/util.py:88
(Diff revision 1)
>  
>      def __setattr__(self, key, value):
>          raise Exception('Object does not support assignment.')
>  
> +    def __ne__(self, other):
> +        return not self == other

I think some parens are warranted here.
Attachment #8736145 - Flags: review?(ted) → review+
Comment on attachment 8736146 [details]
MozReview Request: Bug 1260624 - Move CROSS_COMPILE to moz.configure. r?ted

https://reviewboard.mozilla.org/r/43141/#review40119
Attachment #8736146 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/2d041429d993
https://hg.mozilla.org/mozilla-central/rev/dc8b68b4f67a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.