1260640 - Update nsNSSCertificateDB::getCertsFromPackage() so callers don't need to convert the returned certs into usable formats

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P5)

Description

[:Cykesiopka]

nsNSSCertificateDB::getCertsFromPackage() (in concert with collect_certs()) currently takes a raw buffer, decodes the certs within, and returns those certs as an array of SECItems via the |rawCerts| member of a CERTDERCerts struct.

This is problematic, because at least some callers of the method instead require an array of SECItem *pointers*, and have to manually convert to the appropriate format. ImportCertsIntoTempStorage() is an example function that has to deal with this: https://hg.mozilla.org/mozilla-central/file/df87a62ca357/security/manager/ssl/nsNSSCertificateDB.cpp#l501.

If possible, getCertsFromPackage() should be modified so that this sort of manual conversion is not required.

Comment 1

[Moritz Birghan [:mbirghan]]

Attachment: Bug 1260640 - Update nsNSSCertificateDB::getCertsFromPackage() so callers don't need to convert the returned certs into usable formats

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1525cf59dd27
Update nsNSSCertificateDB::getCertsFromPackage() so callers don't need to convert the returned certs into usable formats r=keeler

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/1525cf59dd27