1260647 - Unify cross-compilation setup, while moving some of it to moz.configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1260647 - Unify cross-compilation setup, while moving some of it to moz.configure. r?ted

Gonk, Android, and the generic cross-compilation setup all were using a
different yet similar way to prefix the toolchain. The latter was even
wrong, since the target and target alias usually don't match actual
toolchain prefixes (which don't include the machine part of the target).

Review commit: https://reviewboard.mozilla.org/r/43153/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43153/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8736165 [details]
MozReview Request: Bug 1260647 - Unify cross-compilation setup, while moving some of it to moz.configure. r?ted

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43153/diff/1-2/

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8736165 [details]
MozReview Request: Bug 1260647 - Unify cross-compilation setup, while moving some of it to moz.configure. r?ted

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43153/diff/2-3/

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://reviewboard.mozilla.org/r/43153/#review39747

::: js/src/old-configure.in:94
(Diff revision 3)
>      ANDROID_VERSION=15
>      if test -n "${PLATFORM_SDK_VERSION}"; then
>          ANDROID_VERSION="${PLATFORM_SDK_VERSION}"
>      fi
>  
>      dnl set up compilers

Ditto

::: old-configure.in:113
(Diff revision 3)
>      ANDROID_VERSION=15
>      if test -n "${PLATFORM_SDK_VERSION}"; then
>          ANDROID_VERSION="${PLATFORM_SDK_VERSION}"
>      fi
>  
>      dnl set up compilers

Remove?

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 8736165 [details]
MozReview Request: Bug 1260647 - Unify cross-compilation setup, while moving some of it to moz.configure. r?ted

https://reviewboard.mozilla.org/r/43153/#review40139

The more you dig out of old-configure the more I'm amazed it worked as well as it did!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f5f41c619be

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0f5f41c619be