Closed Bug 1260647 Opened 4 years ago Closed 4 years ago

Unify cross-compilation setup, while moving some of it to moz.configure

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

No description provided.
Gonk, Android, and the generic cross-compilation setup all were using a
different yet similar way to prefix the toolchain. The latter was even
wrong, since the target and target alias usually don't match actual
toolchain prefixes (which don't include the machine part of the target).

Review commit: https://reviewboard.mozilla.org/r/43153/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43153/
Attachment #8736165 - Flags: review?(ted)
Attachment #8736165 - Flags: review?(ted)
Comment on attachment 8736165 [details]
MozReview Request: Bug 1260647 - Unify cross-compilation setup, while moving some of it to moz.configure. r?ted

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43153/diff/1-2/
Attachment #8736165 - Flags: review?(ted)
Duplicate of this bug: 1184202
Comment on attachment 8736165 [details]
MozReview Request: Bug 1260647 - Unify cross-compilation setup, while moving some of it to moz.configure. r?ted

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43153/diff/2-3/
https://reviewboard.mozilla.org/r/43153/#review39747

::: js/src/old-configure.in:94
(Diff revision 3)
>      ANDROID_VERSION=15
>      if test -n "${PLATFORM_SDK_VERSION}"; then
>          ANDROID_VERSION="${PLATFORM_SDK_VERSION}"
>      fi
>  
>      dnl set up compilers

Ditto

::: old-configure.in:113
(Diff revision 3)
>      ANDROID_VERSION=15
>      if test -n "${PLATFORM_SDK_VERSION}"; then
>          ANDROID_VERSION="${PLATFORM_SDK_VERSION}"
>      fi
>  
>      dnl set up compilers

Remove?
Comment on attachment 8736165 [details]
MozReview Request: Bug 1260647 - Unify cross-compilation setup, while moving some of it to moz.configure. r?ted

https://reviewboard.mozilla.org/r/43153/#review40139

The more you dig out of old-configure the more I'm amazed it worked as well as it did!
Attachment #8736165 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/0f5f41c619be
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.