Unify cross-compilation setup, while moving some of it to moz.configure

RESOLVED FIXED in Firefox 48

Status

RESOLVED FIXED
3 years ago
7 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla48

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8736165 [details]
MozReview Request: Bug 1260647 - Unify cross-compilation setup, while moving some of it to moz.configure. r?ted

Gonk, Android, and the generic cross-compilation setup all were using a
different yet similar way to prefix the toolchain. The latter was even
wrong, since the target and target alias usually don't match actual
toolchain prefixes (which don't include the machine part of the target).

Review commit: https://reviewboard.mozilla.org/r/43153/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43153/
Attachment #8736165 - Flags: review?(ted)
(Assignee)

Updated

3 years ago
Attachment #8736165 - Flags: review?(ted)
(Assignee)

Comment 2

3 years ago
Comment on attachment 8736165 [details]
MozReview Request: Bug 1260647 - Unify cross-compilation setup, while moving some of it to moz.configure. r?ted

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43153/diff/1-2/
Attachment #8736165 - Flags: review?(ted)
(Assignee)

Updated

3 years ago
Duplicate of this bug: 1184202
(Assignee)

Comment 4

3 years ago
Comment on attachment 8736165 [details]
MozReview Request: Bug 1260647 - Unify cross-compilation setup, while moving some of it to moz.configure. r?ted

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43153/diff/2-3/
https://reviewboard.mozilla.org/r/43153/#review39747

::: js/src/old-configure.in:94
(Diff revision 3)
>      ANDROID_VERSION=15
>      if test -n "${PLATFORM_SDK_VERSION}"; then
>          ANDROID_VERSION="${PLATFORM_SDK_VERSION}"
>      fi
>  
>      dnl set up compilers

Ditto

::: old-configure.in:113
(Diff revision 3)
>      ANDROID_VERSION=15
>      if test -n "${PLATFORM_SDK_VERSION}"; then
>          ANDROID_VERSION="${PLATFORM_SDK_VERSION}"
>      fi
>  
>      dnl set up compilers

Remove?
Comment on attachment 8736165 [details]
MozReview Request: Bug 1260647 - Unify cross-compilation setup, while moving some of it to moz.configure. r?ted

https://reviewboard.mozilla.org/r/43153/#review40139

The more you dig out of old-configure the more I'm amazed it worked as well as it did!
Attachment #8736165 - Flags: review?(ted) → review+

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0f5f41c619be
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48

Updated

7 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.