Closed Bug 1260672 Opened 8 years ago Closed 8 years ago

Convert Gonk HAL to |UniquePtr|

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
2.6 S11 - 4/8
Tracking Status
firefox48 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Details

Attachments

(3 files)

|nsAutoPtr| is going away in favor of |UniquePtr|. Gonk's HAL code has to be converted accordingly.
Comment on attachment 8736238 [details] [diff] [review]
[01] Bug 1260672: Use |UniquePtr| for Gonk sensors

Review of attachment 8736238 [details] [diff] [review]:
-----------------------------------------------------------------

Looking good!
Attachment #8736238 - Flags: review?(gsvelto) → review+
Comment on attachment 8736240 [details] [diff] [review]
[02] Bug 1260672: Use |UniquePtr| for Gonk alarms

Review of attachment 8736240 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8736240 - Flags: review?(gsvelto) → review+
Comment on attachment 8736241 [details] [diff] [review]
[03] Bug 1260672: Remove 'nsAutoPtr.h' and clean up includes of Gonk diskspace watcher

Review of attachment 8736241 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8736241 - Flags: review?(gsvelto) → review+
You need to log in before you can comment on or make changes to this bug.