Closed
Bug 1260672
Opened 8 years ago
Closed 8 years ago
Convert Gonk HAL to |UniquePtr|
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
2.6 S11 - 4/8
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
Details
Attachments
(3 files)
7.74 KB,
patch
|
gsvelto
:
review+
|
Details | Diff | Splinter Review |
1.71 KB,
patch
|
gsvelto
:
review+
|
Details | Diff | Splinter Review |
953 bytes,
patch
|
gsvelto
:
review+
|
Details | Diff | Splinter Review |
|nsAutoPtr| is going away in favor of |UniquePtr|. Gonk's HAL code has to be converted accordingly.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8736238 -
Flags: review?(gsvelto)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8736240 -
Flags: review?(gsvelto)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8736241 -
Flags: review?(gsvelto)
Comment 4•8 years ago
|
||
Comment on attachment 8736238 [details] [diff] [review] [01] Bug 1260672: Use |UniquePtr| for Gonk sensors Review of attachment 8736238 [details] [diff] [review]: ----------------------------------------------------------------- Looking good!
Attachment #8736238 -
Flags: review?(gsvelto) → review+
Comment 5•8 years ago
|
||
Comment on attachment 8736240 [details] [diff] [review] [02] Bug 1260672: Use |UniquePtr| for Gonk alarms Review of attachment 8736240 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8736240 -
Flags: review?(gsvelto) → review+
Comment 6•8 years ago
|
||
Comment on attachment 8736241 [details] [diff] [review] [03] Bug 1260672: Remove 'nsAutoPtr.h' and clean up includes of Gonk diskspace watcher Review of attachment 8736241 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8736241 -
Flags: review?(gsvelto) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/90e08b7ccdd3 https://hg.mozilla.org/integration/mozilla-inbound/rev/1fde84b4a3a1 https://hg.mozilla.org/integration/mozilla-inbound/rev/860aa4598f13
Assignee | ||
Comment 8•8 years ago
|
||
Thanks Gabriele https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=860aa4598f13
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/90e08b7ccdd3 https://hg.mozilla.org/mozilla-central/rev/1fde84b4a3a1 https://hg.mozilla.org/mozilla-central/rev/860aa4598f13
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S11 - 4/8
You need to log in
before you can comment on or make changes to this bug.
Description
•