Closed Bug 1260681 Opened 5 years ago Closed 5 years ago

bundle upload does not hard fail for missing credentials

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hwine, Assigned: gps)

References

Details

Attachments

(1 file)

when credentials are not installed, or are invalid, for upload of bundles to S3, no explicit error is given. This made diagnosis of bug 1260652 harder than it should have been :)
Duplicate of this bug: 1260682
I'll fix this and the problem of advertising bundles that didn't upload properly.
Assignee: nobody → gps
Status: NEW → ASSIGNED
TIL that Python futures in concurrent.futures swallow exceptions. I
thought they were behaving like Python threads where an exception in any
thread would terminate program execution. It turns out you need to
explicitly check Future.result() or Future.exception() to see if
the thing raised an exception.

Tests demonstrating the script fails under various conditions have been
added.

Review commit: https://reviewboard.mozilla.org/r/43223/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43223/
Attachment #8736338 - Flags: review?(klibby)
Comment on attachment 8736338 [details]
MozReview Request: sripts/generate-hg-s3-bundles: check for errors (bug 1260681); r?fubar

https://reviewboard.mozilla.org/r/43223/#review39831

lgtm
Attachment #8736338 - Flags: review?(klibby) → review+
This was fixed 22 days ago.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.