1260702 - Crash with WebAudio inputs to MediaRecorder in MediaRecorder::InitEncoder()

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[Soledad Penades [:sole] [:spenades]]

This bug was filed from the Socorro interface and is 
report bp-b70d5d9c-66af-4118-bcbd-01fa52160330.
=============================================================

STR

1. Go to http://mozdevs.github.io/boo/
2. Accept camera & mic usage. Press record button
3. Browser will crash on reaching the zero countdown

This happens when the recorder tries to start recording as in here:
https://github.com/mozdevs/boo/blob/master/app/js/Boo.js#L115

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Don't crash on input sources from WebAudio in MediaRecorder

MozReview-Commit-ID: cseol6STUw

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1fd5dcb62bc4

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8736305 [details] [diff] [review]
Don't crash on input sources from WebAudio in MediaRecorder

Approval Request Comment
[Feature/regressing bug #]: Bug 1257318

[User impact if declined]: WebAudio sources break MediaRecorder

[Describe test coverage new/current, TreeHerder]: No test currently; we'll look to add one on a separate bug.  Manual testing is trivial using the link here; 100% reproducible.

[Risks and why]: No risk to speak of.  null-check

[String/UUID change made/needed]: none

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8736305 [details] [diff] [review]
Don't crash on input sources from WebAudio in MediaRecorder

null-check, crash fix, Aurora47+

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Does this bug also need to be uplifted to 46? Just checking to be sure.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1fd5dcb62bc4

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c9d25791f821

Comment 8

[Carsten Book [:Tomcat]]

(In reply to Randell Jesup [:jesup] from comment #7)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/c9d25791f821

setting flags