If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Crash with WebAudio inputs to MediaRecorder in MediaRecorder::InitEncoder()

RESOLVED FIXED in Firefox 47

Status

()

Core
Audio/Video: Recording
--
critical
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sole, Assigned: jesup)

Tracking

({crash, DevAdvocacy})

unspecified
mozilla48
Unspecified
Mac OS X
crash, DevAdvocacy
Points:
---

Firefox Tracking Flags

(firefox46 unaffected, firefox47 fixed, firefox48 fixed)

Details

(crash signature)

Attachments

(1 attachment)

This bug was filed from the Socorro interface and is 
report bp-b70d5d9c-66af-4118-bcbd-01fa52160330.
=============================================================

STR

1. Go to http://mozdevs.github.io/boo/
2. Accept camera & mic usage. Press record button
3. Browser will crash on reaching the zero countdown

This happens when the recorder tries to start recording as in here:
https://github.com/mozdevs/boo/blob/master/app/js/Boo.js#L115
(Reporter)

Updated

2 years ago
Keywords: DevAdvocacy
(Assignee)

Comment 1

2 years ago
Created attachment 8736305 [details] [diff] [review]
Don't crash on input sources from WebAudio in MediaRecorder

MozReview-Commit-ID: cseol6STUw
Attachment #8736305 - Flags: review?(padenot)
(Assignee)

Updated

2 years ago
Assignee: nobody → rjesup
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Summary: crash in ReceivePort::WaitForMessage | mozilla::ipc::SharedMemoryBasic::ShareToProcess → Crash with WebAudio inputs to MediaRecorder in MediaRecorder::InitEncoder()

Updated

2 years ago
Attachment #8736305 - Flags: review?(padenot) → review+

Comment 2

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fd5dcb62bc4
(Assignee)

Comment 3

2 years ago
Comment on attachment 8736305 [details] [diff] [review]
Don't crash on input sources from WebAudio in MediaRecorder

Approval Request Comment
[Feature/regressing bug #]: Bug 1257318

[User impact if declined]: WebAudio sources break MediaRecorder

[Describe test coverage new/current, TreeHerder]: No test currently; we'll look to add one on a separate bug.  Manual testing is trivial using the link here; 100% reproducible.

[Risks and why]: No risk to speak of.  null-check

[String/UUID change made/needed]: none
Attachment #8736305 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

2 years ago
status-firefox47: --- → affected
status-firefox48: --- → affected

Comment 4

2 years ago
Comment on attachment 8736305 [details] [diff] [review]
Don't crash on input sources from WebAudio in MediaRecorder

null-check, crash fix, Aurora47+
Attachment #8736305 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 5

2 years ago
Does this bug also need to be uplifted to 46? Just checking to be sure.
status-firefox46: --- → ?
(Assignee)

Updated

2 years ago
status-firefox46: ? → unaffected

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1fd5dcb62bc4
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
(Assignee)

Comment 7

2 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/c9d25791f821
(In reply to Randell Jesup [:jesup] from comment #7)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/c9d25791f821

setting flags
status-firefox47: affected → fixed

Updated

2 years ago
See Also: → bug 1264209
You need to log in before you can comment on or make changes to this bug.