Closed Bug 1260744 Opened 4 years ago Closed 4 years ago

Today Pane: missing icon on buttons to cycle between "events", "tasks", and "events & tasks"

Categories

(Calendar :: Lightning Only, defect)

Lightning 5.0
Unspecified
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ssitter, Assigned: Paenglab)

References

Details

Attachments

(2 files, 1 obsolete file)

Lightning 5.0a1 (Build ID 20160330030310) with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:48.0) Gecko/20100101 Thunderbird/48.0a1

In Today Pane the buttons to cycle between "events", "tasks", and "events & tasks" are missing icon and style.
Bug 700976 removed the styles. I'll add them in Lightning.
Blocks: 700976
Attached patch folderview-cycler.patch (obsolete) — Splinter Review
All folderview-cycler rules are now in Lightning.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8736361 - Flags: review?(ssitter)
Sorry, I didn't expect "folderview-*" classes used outside the folderview. Maybe they could get renamed now?
OK, previously Lightning was reusing the folderview-cycler style as defined by Thunderbird and SeaMonkey. With your patch applied, how does it look in SeaMonkey when both Lightning and SeaMonkey now define a folderview-cycler style? Are there conflicts? If yes, maybe the style should be renamed (e.g. today-pane-cycler) and make it work in both Thunderbird and SeaMonkey?
It seems we still have remnants of the folderview-cycler css in TB. It seems SM also only ships the css but has no usage of it (maybe only for calendar).

So in addition to comment 4, there are other options:
2. put the style back to TB, with a generic name (like "cycler-arrows") and also rename it in SM.
3. remove the style also from SM and put only into LT (with or without renaming)
Comment on attachment 8736361 [details] [diff] [review]
folderview-cycler.patch

Yes, suite has only the styles. To be safe I rename the cyclers and move the icons to Lightning (I need to check if they are still used in TB).
Attachment #8736361 - Flags: review?(ssitter)
This patch changes the class to today-pane-cycler and uses the own images for the arrows.

I leaved suite unchanged.
Attachment #8736361 - Attachment is obsolete: true
Attachment #8736429 - Flags: review?(ssitter)
Attachment #8736429 - Flags: review?(ssitter) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/0e4f93f7092b9636d53625a2ac8118c17c61d363
Bug 1260744 - Re-add the in bug 700976 removed folderview-cycler styles in Lightning. r=ssitter
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 5.0
You need to log in before you can comment on or make changes to this bug.