1260756 - The SyntaxTreeVisitor in Parser.jsm fails to process template literals and function default arguments

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Jarda Snajdr [:jsnajdr]]

Steps to reproduce:
1. Try to debug a script like this:

function(first, second = "") {
  return `${first} + ${second}`;
}

2. Do something that involves running the SyntaxTreeVisitor. Either mouseover a variable name to trigger variable bubble view, or search in function names (@something).

Actual result:
The SyntaxTreeVisitor has two bugs that lead to TypeError:
1. No support for handling the TemplateLiteral type. Tries to call an undefined member function.
2. Incorrectly handles function defaults list where the first argument doesn't have any default. The defaults list for the function above is then [null, ""], and the code is not prepared for the "null". Happens for FunctionDefinition, FunctionExpression and ArrayFunctionExpression.

Comment 1

[Jarda Snajdr [:jsnajdr]]

Attachment: The SyntaxTreeVisitor in Parser.jsm fails to process template literals and function default arguments.

Comment 2

[Jarda Snajdr [:jsnajdr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0820bd17f3e9

Comment 3

[Jarda Snajdr [:jsnajdr]]

Attachment: make Parser.jsm ESLint-clean.

...except one error - "uneval" function is not defined.

Comment 4

[Jarda Snajdr [:jsnajdr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eac826d3ed4f

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2bc47d801b32
https://hg.mozilla.org/integration/fx-team/rev/22e771b7f16c

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2bc47d801b32
https://hg.mozilla.org/mozilla-central/rev/22e771b7f16c