1260823 - MozillaBuild 2.2.0 won't start when MOZ_NO_RESET_PATH is set if existing PATH contains spaces

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[(No longer employed by Mozilla) Aaron Klotz]

In start-shell.bat, the line:
  SET PATH=%PATH%;!LLVMDIR!\bin

fails if PATH contains any spaces. Adding quotes like so:

  SET PATH="%PATH%;!LLVMDIR!\bin"

appears to have fixed it.

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

This might be what I was seeing. I got an error saying something like 'Usage of "\PHP\" is incorrect'. I downgraded to MozillaBuild 2.1.0 and it appears to have fixed the problem.

Comment 2

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Seeing this on my home computer too.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Attachment: quote value containing delayfully-expanded variable

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8738221 [details] [diff] [review]
quote value containing delayfully-expanded variable

Review of attachment 8738221 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

https://hg.mozilla.org/mozilla-build/rev/baebf7d4dffa

Comment 7

[Ryan VanderMeulen [:RyanVM]]

I'll try to spin a new release soon to pick up this fix.

Comment 8

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)
> I'll try to spin a new release soon to pick up this fix.

Hi Ryan! Any update on this?

Comment 9

[Ryan VanderMeulen [:RyanVM]]

We're going in a different direction. Greg has an intern who's got msys2 nearly completely functional for building Firefox, which will entirely obsolete MozillaBuild. As a result, the plan is to not ship any new releases unless a critical issue appears.

Comment 10

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Ok, good to hear! For what it's worth, I'm stuck on MozillaBuild 2.1.0 on all my machines due to this bug so hopefully msys2 comes soon!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Sorry for the annoyance. You can always make the start-shell.bat tweak from the attached patch locally post-install, though.

Comment 12

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Oh I didn't realize it was a simple as editing the batch file. That's great. Thanks!