Closed Bug 1260888 Opened 4 years ago Closed 4 years ago

Enable extension xpcshell tests to run on Android.

Categories

(WebExtensions :: Untriaged, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Iteration:
48.3 - Apr 25
Tracking Status
firefox48 --- fixed

People

(Reporter: mattw, Assigned: mattw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Enable extension xpcshell tests to run on Android.
Summary: Enable mochitests for extensions to run on Android → Enable extension xpcshell tests to run on Android.
If I did the try run correctly, then I think enabling the tests is all that needs to be done here.
(In reply to Matthew Wein [:mattw] from comment #2)
> If I did the try run correctly, then I think enabling the tests is all that
> needs to be done here.

Sadly that try run didn't run any xpcshell tests; there would be X's.  I would try:

hg push-to-try -m "try: -b o -p android-api-15,android-x86 -u xpcshell"
I added the xpcshell jobs to the try run, and it looks like you have a failure: https://treeherder.mozilla.org/logviewer.html#?job_id=18868129&repo=try
I disabled the failing test on android and created a follow-up bug to fix it because it doesn't seem like the fix is trivial.

Kris suggested that the issue might be in the way we're setting up the xpcshell tests. I'm basically going to copy now what he told me over IRC: Specifically, the firefox-appdir in xpcshell.ini is set to `browser` when that might not work on fennec. We can't just update the firefox-appdir to 'mobile/android' because you can't set two appdirs in the same manifest. If we need to make that kind of change, the two options are to either skip the test on Android, or add another manifest that's android-specific. There might be a better option, but I don't know one off the top of my head.
Comment on attachment 8736565 [details]
MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43389/diff/1-2/
Attachment #8736565 - Attachment description: MozReview Request: Bug 1260888 Enable the extension xpcshell tests on Android. r?nalexander → MozReview Request: Bug 1260888 Enable the extension xpcshell tests on Android. try: -b o -p android-api-15,android-x86 -u xpcshell
Blocks: 1261253
Comment on attachment 8736565 [details]
MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.

Clearing review -- this has been addressed.
Attachment #8736565 - Flags: review?(nalexander)
Attachment #8736565 - Attachment description: MozReview Request: Bug 1260888 Enable the extension xpcshell tests on Android. try: -b o -p android-api-15,android-x86 -u xpcshell → MozReview Request: Bug 1260888 Enable the extension xpcshell tests on Android.
Attachment #8736565 - Flags: review?(kmaglione+bmo)
Comment on attachment 8736565 [details]
MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43389/diff/2-3/
Attachment #8736565 - Flags: review?(kmaglione+bmo) → review?(nalexander)
Attachment #8736565 - Flags: review?(nalexander) → review?(kmaglione+bmo)
Kris noticed that the tests are all passing now, so the firefox-appdir issue might actually not be an issue at all.  I also reran the tests on try and noticed that they all pass now as well:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=502a1625600c
Comment on attachment 8736565 [details]
MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43389/diff/3-4/
Attachment #8736565 - Attachment description: MozReview Request: Bug 1260888 Enable the extension xpcshell tests on Android. → MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.
Attachment #8736565 - Flags: review?(kmaglione+bmo) → review?(nalexander)
Attachment #8736565 - Flags: review?(nalexander) → review?(kmaglione+bmo)
Comment on attachment 8736565 [details]
MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.

https://reviewboard.mozilla.org/r/43389/#review41819

wfm.
Attachment #8736565 - Flags: review+
https://reviewboard.mozilla.org/r/43389/#review41819

mattw: just FYI, I'll be mostly out of the Android team for a while.  gbrown is the person to flag for future reviews.
Iteration: 48.2 - Apr 4 → 48.3 - Apr 25
Comment on attachment 8736565 [details]
MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.

This only needs one review.
Attachment #8736565 - Flags: review?(kmaglione+bmo)
Comment on attachment 8736565 [details]
MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43389/diff/4-5/
Thanks Nick.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/aabcf6fbbc46
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.