1260888 - Enable extension xpcshell tests to run on Android.

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Matthew Wein [:mattw]]

Enable extension xpcshell tests to run on Android.

Comment 1

[Matthew Wein [:mattw]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=44e2c81a0696

Comment 2

[Matthew Wein [:mattw]]

If I did the try run correctly, then I think enabling the tests is all that needs to be done here.

Comment 3

[Matthew Wein [:mattw]]

Attachment: MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.

Review commit: https://reviewboard.mozilla.org/r/43389/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43389/

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Matthew Wein [:mattw] from comment #2)
> If I did the try run correctly, then I think enabling the tests is all that
> needs to be done here.

Sadly that try run didn't run any xpcshell tests; there would be X's.  I would try:

hg push-to-try -m "try: -b o -p android-api-15,android-x86 -u xpcshell"

Comment 5

[Nick Alexander :nalexander [he/him]]

A quick read through https://dxr.mozilla.org/mozilla-central/source/toolkit/components/extensions/test/xpcshell/ suggests these will be green, but one never knows for sure.

Comment 6

[Kris Maglione [:kmag]]

I added the xpcshell jobs to the try run, and it looks like you have a failure: https://treeherder.mozilla.org/logviewer.html#?job_id=18868129&repo=try

Comment 7

[Matthew Wein [:mattw]]

I disabled the failing test on android and created a follow-up bug to fix it because it doesn't seem like the fix is trivial.

Kris suggested that the issue might be in the way we're setting up the xpcshell tests. I'm basically going to copy now what he told me over IRC: Specifically, the firefox-appdir in xpcshell.ini is set to `browser` when that might not work on fennec. We can't just update the firefox-appdir to 'mobile/android' because you can't set two appdirs in the same manifest. If we need to make that kind of change, the two options are to either skip the test on Android, or add another manifest that's android-specific. There might be a better option, but I don't know one off the top of my head.

Comment 8

[Matthew Wein [:mattw]]

Follow-up bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1261253

Comment 9

[Matthew Wein [:mattw]]

Comment on attachment 8736565 [details]
MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43389/diff/1-2/

Comment 10

[Matthew Wein [:mattw]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=40a83fd222fe

Comment 11

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8736565 [details]
MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.

Clearing review -- this has been addressed.

Comment 12

[Matthew Wein [:mattw]]

Comment on attachment 8736565 [details]
MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43389/diff/2-3/

Comment 13

[Matthew Wein [:mattw]]

Kris noticed that the tests are all passing now, so the firefox-appdir issue might actually not be an issue at all.  I also reran the tests on try and noticed that they all pass now as well:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=502a1625600c

Comment 14

[Matthew Wein [:mattw]]

Comment on attachment 8736565 [details]
MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43389/diff/3-4/

Comment 15

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8736565 [details]
MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.

https://reviewboard.mozilla.org/r/43389/#review41819

wfm.

Comment 16

[Nick Alexander :nalexander [he/him]]

https://reviewboard.mozilla.org/r/43389/#review41819

mattw: just FYI, I'll be mostly out of the Android team for a while.  gbrown is the person to flag for future reviews.

Comment 17

[Kris Maglione [:kmag]]

Comment on attachment 8736565 [details]
MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.

This only needs one review.

Comment 18

[Matthew Wein [:mattw]]

Comment on attachment 8736565 [details]
MozReview Request: Bug 1260888 - Enable the extension xpcshell tests on Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43389/diff/4-5/

Comment 19

[Matthew Wein [:mattw]]

Thanks Nick.

Comment 20

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/aabcf6fbbc46

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/aabcf6fbbc46