1260930 - Add "Logins" group in Settings > Privacy

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Our Privacy settings section looks a bit jumbled... 

A quick fix is grouping "Manage logins", "Remember logins", and "Use master password", under a separate header/group titled, "Logins".

With that, we can move "Clear private data on exit" to be above this group, right after "Cookies".

So the new order would be:

Do not track
Tracking protection
Cookies
Clear private data on exit
Logins (a group)
Data choices (a group)

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

.. I'm currently working on some other settings bugs - I can pick this up.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: privacy.png

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1260930 - Settings: Add "Logins" group in Settings > Privacy. r?ahunt

Review commit: https://reviewboard.mozilla.org/r/43569/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43569/

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8736824 [details]
privacy.png

Awesome!

Comment 5

[Andrzej Hunt :ahunt]

Comment on attachment 8736832 [details]
MozReview Request: Bug 1260930 - Settings: Add "Logins" group in Settings > Privacy. r?ahunt

https://reviewboard.mozilla.org/r/43569/#review40389

Very nice! (I've stumbled over this a few times recently!)

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/38ee8634a647f86264120b70a28f8703b80d0657
Bug 1260930 - Settings: Add "Logins" group in Settings > Privacy. r=ahunt

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/38ee8634a647

Comment 8

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2016-04-06-15-01-53.png

verified as fixed using:
Device: Nexus 7 (Android 5.1.1)
Build: Firefox for Android 48.0a1 (2016-04-05)