Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS on cross compiles

RESOLVED FIXED in Firefox 48

Status

Firefox Build System
General
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla48
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Blocks: 1259382
(Assignee)

Comment 1

2 years ago
Created attachment 8736627 [details]
MozReview Request: Bug 1260996 - Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS on cross compiles. r?gps

The only cross compiles we actively support were resetting pre-setting those
values to avoid it anyways, so it wasn't doing anything useful.

Review commit: https://reviewboard.mozilla.org/r/43465/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43465/
Attachment #8736627 - Flags: review?(gps)
(Assignee)

Comment 2

2 years ago
Comment on attachment 8736627 [details]
MozReview Request: Bug 1260996 - Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS on cross compiles. r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43465/diff/1-2/
Comment on attachment 8736627 [details]
MozReview Request: Bug 1260996 - Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS on cross compiles. r?gps

https://reviewboard.mozilla.org/r/43465/#review40215

Makes sense.  The commit message needs to be fixed though: "resetting pre-setting" reads badly.
Attachment #8736627 - Flags: review+
I've had to work around this so many times. This never made sense to me!

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/04e7a688a7df
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
(Assignee)

Updated

2 years ago
Blocks: 1261359

Updated

2 years ago
Attachment #8736627 - Flags: review?(gps)

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.