Closed Bug 1260996 Opened 4 years ago Closed 4 years ago

Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS on cross compiles

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

No description provided.
Blocks: 1259382
The only cross compiles we actively support were resetting pre-setting those
values to avoid it anyways, so it wasn't doing anything useful.

Review commit: https://reviewboard.mozilla.org/r/43465/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43465/
Attachment #8736627 - Flags: review?(gps)
Comment on attachment 8736627 [details]
MozReview Request: Bug 1260996 - Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS on cross compiles. r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43465/diff/1-2/
Comment on attachment 8736627 [details]
MozReview Request: Bug 1260996 - Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS on cross compiles. r?gps

https://reviewboard.mozilla.org/r/43465/#review40215

Makes sense.  The commit message needs to be fixed though: "resetting pre-setting" reads badly.
Attachment #8736627 - Flags: review+
I've had to work around this so many times. This never made sense to me!
https://hg.mozilla.org/mozilla-central/rev/04e7a688a7df
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Blocks: 1261359
Attachment #8736627 - Flags: review?(gps)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.