Closed
Bug 1260996
Opened 9 years ago
Closed 9 years ago
Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS on cross compiles
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
The only cross compiles we actively support were resetting pre-setting those
values to avoid it anyways, so it wasn't doing anything useful.
Review commit: https://reviewboard.mozilla.org/r/43465/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43465/
Attachment #8736627 -
Flags: review?(gps)
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8736627 [details]
MozReview Request: Bug 1260996 - Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS on cross compiles. r?gps
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43465/diff/1-2/
Comment 3•9 years ago
|
||
Comment on attachment 8736627 [details]
MozReview Request: Bug 1260996 - Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS on cross compiles. r?gps
https://reviewboard.mozilla.org/r/43465/#review40215
Makes sense. The commit message needs to be fixed though: "resetting pre-setting" reads badly.
Attachment #8736627 -
Flags: review+
Comment 5•9 years ago
|
||
I've had to work around this so many times. This never made sense to me!
Comment 6•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•9 years ago
|
Attachment #8736627 -
Flags: review?(gps)
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•