1260996 - Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS on cross compiles

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1260996 - Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS on cross compiles. r?gps

The only cross compiles we actively support were resetting pre-setting those
values to avoid it anyways, so it wasn't doing anything useful.

Review commit: https://reviewboard.mozilla.org/r/43465/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43465/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8736627 [details]
MozReview Request: Bug 1260996 - Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS on cross compiles. r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43465/diff/1-2/

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8736627 [details]
MozReview Request: Bug 1260996 - Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS on cross compiles. r?gps

https://reviewboard.mozilla.org/r/43465/#review40215

Makes sense.  The commit message needs to be fixed though: "resetting pre-setting" reads badly.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/04e7a688a7df

Comment 5

[(not currently active) Ted Mielczarek]

I've had to work around this so many times. This never made sense to me!

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/04e7a688a7df