Remove SocialShareDropdown & associated code

RESOLVED FIXED

Status

Hello (Loop)
Client
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tech-debt])

User Story

- Remove SocialShareDropdown from roomViews.jsx
- Remove any associated props in the call tree
- Remove any associated actions, their functions, and code in MozLoopAPI (e.g. AddSocialShareProvider/ShareRoomUrl)
- Remove any associated strings

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The SocialShareDropdown never gets displayed now. We should just remove it and avoid needing to maintain it.
(Assignee)

Updated

2 years ago
Assignee: nobody → standard8
Created attachment 8758485 [details] [review]
[loop] Standard8:bug-1261005-socialshare > mozilla:master
(Assignee)

Comment 2

2 years ago
Comment on attachment 8758485 [details] [review]
[loop] Standard8:bug-1261005-socialshare > mozilla:master

Since we never show the SocialShareDropdown now, this code needs to go away.

I'm removing it now as it currently makes initialising the conversation window/akita sidebar a lot more complex than it needs to be.

As we're just about to touch that code, I'd rather have this out of the way now.
Attachment #8758485 - Flags: review?(edilee)
Attachment #8758485 - Flags: review?(dcritchley)
Attachment #8758485 - Flags: review?(b.mcb)
Comment on attachment 8758485 [details] [review]
[loop] Standard8:bug-1261005-socialshare > mozilla:master

Looks good. Ship it
Attachment #8758485 - Flags: review?(edilee)
Attachment #8758485 - Flags: review?(dcritchley)
Attachment #8758485 - Flags: review?(b.mcb)
Attachment #8758485 - Flags: review+
(Assignee)

Comment 4

2 years ago
https://github.com/mozilla/loop/commit/b30f94a40c617d35019efff615ed77bb4250b5ac
Status: NEW → RESOLVED
Iteration: --- → 49.3 - Jun 6
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Blocks: 1281619
You need to log in before you can comment on or make changes to this bug.