Closed Bug 1261039 Opened 4 years ago Closed 4 years ago

Remove Honeycomb code guarded by AppConstants.Versions.preHCMR1 / preHCMR2

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: sebastian, Assigned: jorick.caberio, Mentored)

References

Details

Attachments

(2 files)

Attached patch mypatch.diffSplinter Review
Attachment #8738918 - Flags: review?(s.kaspari)
Assignee: nobody → jorick.caberio
Status: NEW → ASSIGNED
Comment on attachment 8738918 [details] [diff] [review]
mypatch.diff

Review of attachment 8738918 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good. Can you remove the (now unused) constant Versions.preHCMR1 too? If you upload a new patch then I'll push it to the tryserver and we can see if this causes any issues.
Attachment #8738918 - Flags: review?(s.kaspari) → feedback+
Attachment #8739350 - Flags: review+
Attachment #8739350 - Flags: feedback?(s.kaspari)
Comment on attachment 8739350 [details] [diff] [review]
mythirdpatch.diff

LGTM. Thanks :)

I'll fold the changes into one and land this.
Attachment #8739350 - Flags: review+
Attachment #8739350 - Flags: feedback?(s.kaspari)
https://hg.mozilla.org/integration/fx-team/rev/4c690a8ab43db8d8a0b4e65a4f67f79556d6a00b
Bug 1261039 - Remove Honeycomb code guarded by AppConstants.Versions.preHCMR1 / preHCMR2. r=sebastian
Thanks for mentoring this bug!
https://hg.mozilla.org/mozilla-central/rev/4c690a8ab43d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.