Closed
Bug 1261039
Opened 8 years ago
Closed 8 years ago
Remove Honeycomb code guarded by AppConstants.Versions.preHCMR1 / preHCMR2
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: sebastian, Assigned: jorick.caberio, Mentored)
References
Details
Attachments
(2 files)
2.77 KB,
patch
|
sebastian
:
feedback+
|
Details | Diff | Splinter Review |
1.78 KB,
patch
|
sebastian
:
review+
|
Details | Diff | Splinter Review |
Honeycomb-only code shouldn't be needed anymore: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/AppConstants.java.in#72-73
Assignee | ||
Comment 1•8 years ago
|
||
Hi I would to take on this bug. It's essential removing the following lines of code, right? https://dxr.mozilla.org/mozilla-central/rev/68c0b7d6f16ce5bb023e08050102b5f2fe4aacd8/mobile/android/base/java/org/mozilla/gecko/gfx/JavaPanZoomController.java#308-310 https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/gfx/JavaPanZoomController.java#328-330
Assignee | ||
Comment 2•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8738918 -
Flags: review?(s.kaspari)
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → jorick.caberio
Status: NEW → ASSIGNED
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8738918 [details] [diff] [review] mypatch.diff Review of attachment 8738918 [details] [diff] [review]: ----------------------------------------------------------------- This looks good. Can you remove the (now unused) constant Versions.preHCMR1 too? If you upload a new patch then I'll push it to the tryserver and we can see if this causes any issues.
Attachment #8738918 -
Flags: review?(s.kaspari) → feedback+
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8739350 -
Flags: review+
Reporter | ||
Updated•8 years ago
|
Attachment #8739350 -
Flags: feedback?(s.kaspari)
Reporter | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c5b06298592
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8739350 [details] [diff] [review] mythirdpatch.diff LGTM. Thanks :) I'll fold the changes into one and land this.
Attachment #8739350 -
Flags: review+
Attachment #8739350 -
Flags: feedback?(s.kaspari)
Reporter | ||
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/4c690a8ab43db8d8a0b4e65a4f67f79556d6a00b Bug 1261039 - Remove Honeycomb code guarded by AppConstants.Versions.preHCMR1 / preHCMR2. r=sebastian
Assignee | ||
Comment 8•8 years ago
|
||
Thanks for mentoring this bug!
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4c690a8ab43d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•