When clamping the displayport margins to the max texture size, the margin is distributed unevenly

RESOLVED FIXED in Firefox 47

Status

()

RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: kats, Assigned: kats)

Tracking

({regression})

48 Branch
mozilla48
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 wontfix, firefox46 wontfix, firefox47 fixed, firefox48 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The code added in bug 1135907 prevented the displayport from expanding beyond the maximum texture size. However when doing so it calculated a "budget" and then spent as much of the budget as possible on the top/left margin, using the rest for the bottom/right margin. If this code is hit, it can result in the displayport being "skewed" towards the top/left of the visible area, and so checkerboarding occurs more easily when scrolling down/right. This happened in bug 1258051 for example.
Created attachment 8736700 [details] [diff] [review]
Patch
Attachment #8736700 - Flags: review?(dvander)
Attachment #8736700 - Flags: review?(dvander) → review+
Created attachment 8736889 [details] [diff] [review]
Patch for landing

Update r= so patch is ready for landing, to go into landing queue.
Attachment #8736700 - Attachment is obsolete: true
Attachment #8736889 - Flags: review+

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d9d29cea3572
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment on attachment 8736889 [details] [diff] [review]
Patch for landing

Approval Request Comment
[Feature/regressing bug #]: APZ
[User impact if declined]: bug 1258051 is one example - if the user's system has smaller max texture sizes they can run into checkerboarding more frequently. Not many users will run into this problem.
[Describe test coverage new/current, TreeHerder]: tested by reporter of bug 1258051, no automated coverage for this particular bug
[Risks and why]: low risk, the codepath in question is not hit very often. low-impact fix and low risk.
[String/UUID change made/needed]: none
Attachment #8736889 - Flags: approval-mozilla-aurora?
Comment on attachment 8736889 [details] [diff] [review]
Patch for landing

Fix was verified in bug 1258051, Aurora47+
Attachment #8736889 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 7

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/b8a888b7858a
status-firefox47: affected → fixed
Depends on: 1413618
You need to log in before you can comment on or make changes to this bug.