1261092 - Cleanup DeveloperToolbar init/destruction codepath

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Alexandre Poirot [:ochameau]]

Now that we insert the toolbar dynamically, we can simplify how it gets instanciated and destroyed. We can also remove the hardcoded DeveloperToolbar definition from /browser/.

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#160

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Simplify gcli initialization/destruction codepaths.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: patch v2

Rebased.

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8737789 [details] [diff] [review]
patch v2

Review of attachment 8737789 [details] [diff] [review]:
-----------------------------------------------------------------

Feel free to involve Joe, but since you asked for the devtools-unloaded removal I'm flagging you.

::: browser/base/content/browser.js
@@ -160,5 @@
> -XPCOMUtils.defineLazyGetter(this, "DeveloperToolbar", function() {
> -  let { require } = Cu.import("resource://devtools/shared/Loader.jsm", {});
> -  let { DeveloperToolbar } = require("devtools/client/shared/developer-toolbar");
> -  return new DeveloperToolbar(window);
> -});

This is just moved to gDevToolsBrowser, added dynamically to the chrome window.

::: devtools/bootstrap.js
@@ -128,5 @@
> -            if (wasVisible) {
> -              window.DeveloperToolbar.show();
> -            }
> -          });
> -      }

We longer need this, nor listen to load/unload in developer-toolbar
as developer toolbar is no longer a singleton.
It is now a module and no longer a jsm, so it is itself being loaded and unloaded when the module loader does so.
gDevToolsBrowser ensure calling its destroy method.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8737789 [details] [diff] [review]
patch v2

Review of attachment 8737789 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable to me, but let's double check with :jwalker too.

Comment 5

[Joe Walker [:jwalker]]

Comment on attachment 8737789 [details] [diff] [review]
patch v2

Review of attachment 8737789 [details] [diff] [review]:
-----------------------------------------------------------------

Deletes lots of code and hidden dependency.

Comment 6

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/1300b2a51f1d65579b4875f33f0075538e1391b6
Bug 1261092 - Simplify gcli initialization/destruction codepaths. r=jryans,jwalker

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1300b2a51f1d