Closed Bug 1261115 Opened 4 years ago Closed 4 years ago

when Console is running in the main thread the existence of mWindow should always be ensured

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: rpl, Assigned: baku)

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

No description provided.
Assignee: nobody → amarchesini
Are you working on this, baku?
Flags: needinfo?(amarchesini)
Yes, I asked Luca to open this bug and to assign it to me.
Flags: needinfo?(amarchesini)
Attached patch console.patchSplinter Review
Attachment #8739727 - Flags: review?(bugs)
Comment on attachment 8739727 [details] [diff] [review]
console.patch

Do we not ever use those ctors in main thread without window? Like, we don't expose Console to JS components?
Comment on attachment 8739727 [details] [diff] [review]
console.patch

based on the webidl that is the case. Only window context has Console.
Attachment #8739727 - Flags: review?(bugs) → review+
> based on the webidl that is the case. Only window context has Console.

And workers, but they don't run on the main-thread.
Whiteboard: btpp-active
https://hg.mozilla.org/mozilla-central/rev/474f2f3c1059
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.