libcubeb tests don't compile correctly when pulseaudio is disabled

RESOLVED FIXED in Firefox 48

Status

()

Core
Audio/Video: cubeb
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

Trunk
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
libcubeb's moz.build checks MOZ_PULSEAUDIO before adding cubeb_resampler.c, but tests/test_resampler.cpp uses cubeb_resampler_fill unconditionally, leading to linking errors.
(Assignee)

Comment 1

2 years ago
Created attachment 8736783 [details] [diff] [review]
only compile libcubeb's test_resampler if PulseAudio is enabled
Attachment #8736783 - Flags: review?(kinetik)
(Assignee)

Updated

2 years ago
Assignee: nobody → nfroyd
Comment on attachment 8736783 [details] [diff] [review]
only compile libcubeb's test_resampler if PulseAudio is enabled

Review of attachment 8736783 [details] [diff] [review]:
-----------------------------------------------------------------

This effectively disables the test on every other platform (the resampler is also built on Darwin, WINNT, and Android) though, so it's not exactly what we want.

Probably the simplest thing for now is to also include those platforms in the test condition.  r+ with that.
Attachment #8736783 - Flags: review?(kinetik) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/06b7878b2c1d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.