1261116 - libcubeb tests don't compile correctly when pulseaudio is disabled

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect)

Description

[Nathan Froyd [:froydnj]]

libcubeb's moz.build checks MOZ_PULSEAUDIO before adding cubeb_resampler.c, but tests/test_resampler.cpp uses cubeb_resampler_fill unconditionally, leading to linking errors.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: only compile libcubeb's test_resampler if PulseAudio is enabled

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 8736783 [details] [diff] [review]
only compile libcubeb's test_resampler if PulseAudio is enabled

Review of attachment 8736783 [details] [diff] [review]:
-----------------------------------------------------------------

This effectively disables the test on every other platform (the resampler is also built on Darwin, WINNT, and Android) though, so it's not exactly what we want.

Probably the simplest thing for now is to also include those platforms in the test condition.  r+ with that.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/06b7878b2c1d

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/06b7878b2c1d