The "Turn Notifications Off/On" button does not update it's status when clicked

RESOLVED FIXED

Status

Hello (Loop)
Client
P1
normal
Rank:
19
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: pauloiegasSV, Assigned: standard8)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [btpp-fix-now])

Attachments

(1 attachment)

[Affected versions]:
- Nightly 48.0a1, Build ID: 20160331030231
 
[Affected platforms]:
- Windows 10 x32, Windows 7 x32, Ubuntu 15.10 x64

[Steps to reproduce]:
1. Launch Firefox with a new profile and visit a webpage.
2. Click "Hello" button from the Firefox toolbar.
3. Click the "Settings" button from bottom right of the pop up.
4. Click the "Turn Notifications Off" button.
5. Click the "Settings" button again and observe the notification status.	

[Expected result]:
The notifications status has been changed to "On".

[Actual result]:
The notifications status remains in "Off" status.

[Regression range]:
I haven't verified yet if this is a regression issue, but I will investigate it and report back if needed.

[Notes]:
This only affects the UI interface and not the actual functionality of the "Turn Notifications On/Off" button.
(Assignee)

Comment 1

2 years ago
This seems quite a recent regression and is confusing for users who use it. We should fix this I think.
Rank: 19
Priority: -- → P1
Whiteboard: [btpp-fix-now]
I've performed a regression on this issue and this are my results:
Last good revision: 3381aa98edf72e02b9d6b4db6efa0865063a2329
First bad revision: efe7d026ac641759838dd3897c37892e37e5b244
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3381aa98edf72e02b9d6b4db6efa0865063a2329&tochange=efe7d026ac641759838dd3897c37892e37e5b244
(Assignee)

Comment 3

2 years ago
Regression from bug 1249552.
Blocks: 1249552
Keywords: regression
Created attachment 8738105 [details] [review]
[loop] Standard8:bug-1261118-toggle > mozilla:master
(Assignee)

Updated

2 years ago
Assignee: nobody → standard8
(Assignee)

Updated

2 years ago
Attachment #8738105 - Flags: review?(fernando.campo)
Attachment #8738105 - Flags: review?(edilee)
Attachment #8738105 - Flags: review?(b.mcb)
Comment on attachment 8738105 [details] [review]
[loop] Standard8:bug-1261118-toggle > mozilla:master

Looks good. r=me
Attachment #8738105 - Flags: review?(fernando.campo)
Attachment #8738105 - Flags: review?(edilee)
Attachment #8738105 - Flags: review?(b.mcb)
Attachment #8738105 - Flags: review+
(Assignee)

Comment 6

2 years ago
https://github.com/mozilla/loop/commit/b2609681a6f5b36e6a5e3ae6f699b7d7b1c464d5
Status: NEW → RESOLVED
Iteration: --- → 48.3 - Apr 18
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Blocks: 1262522
You need to log in before you can comment on or make changes to this bug.