1261128 - Various issues with doing customisation of toolbar menus/buttons whilst in a conversation

Status: RESOLVED INCOMPLETE

(Hello (Loop) :: Client, defect)

Description

[Paul Pasca[Away. Please needinfo? Paul Oiegas [:pauloiegasSV]]]

[Affected versions]:
- Nightly 48.0a1, Build ID: 20160331030231
 
[Affected platforms]:
- Windows 7 x32

[Steps to reproduce]:
1.Launch Firefox with a new profile and visit a webpage.
2.Click the "Hello" icon and chose to share a tab.
3.Click the "Context menu" button and chose the "Customize" option.
4.Drag the "Hello" icon from tool bar and place it in the "Context menu". 
5.Observe the browser's behavior. 

[Expected result]:
Hello icon is properly placed in the menu.

[Actual result]:
Unable to drag and place the Hello icon into menu. The customize functionality freezes while doing this.  

[Regression range]:
I haven't verified yet if this is a regression issue, but I will investigate it and report back if needed.

[Notes]:
- You have to click "Exit Customize" button for this to work (sometimes it may require to repeat it several 

times).
- This can also occur when trying to drag the "Hello" icon from the "Context menu" to place it on other areas.
- Reproducible 3 out of 5 tries.

Comment 1

[Mark Banner (:standard8)]

We should probably see if its sensible to ban the customization process whilst in a room/call/tab sharing.

It isn't really necessary for the user to do that, so I feel prevention is better than trying to fix all the cases where it might break...

Comment 2

[Paul Pasca[Away. Please needinfo? Paul Oiegas [:pauloiegasSV]]]

I've performed a regression on this issue and this are the results:

Last good revision: 3ac7627f1cf7a049091bc639ea9c2a3e3a9acd72
First bad revision: 93aaf03b7399b9e2efd8d91b2ae060787b002281
Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=3ac7627f1cf7a049091bc639ea9c2a3e3a9acd72&tochange=93aaf03b7399b9e2efd8d91b2ae060787b002281

Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=976940

Comment 4

[Mark Banner (:standard8)]

Grouping these together a bit. There's so far a few issues:

- This bug
- Bug 1266073 where the buttons get messed up
- Bug 1198278 where we do the wrong thing when sharing.

Once we've done the rearchitecture for akita, we should take another look at these and see which apply (I think the last one in the list might).

Comment 5

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.