1261132 - "Start Recording Performance" and "Take snapshot" buttons are black-on-black

Status: VERIFIED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 48, 32bit, ID 20160330030326
STR:
1. Set Dark devtools theme
2. Open Profiler (Shift+F5)

AR:  Black button is barely visible on black background
ER:  Background should be gray, just like in other devtools tabs

Comment 1

[arni2033]

Attachment: screenshot 1 - Start Recording Performance button is black-on-black.png

Comment 2

[Victor Porof [:vporof][:vp]]

Can't work on this right now, busy with Tofino.

Comment 3

[Brad Aytes [:eights]]

I would like to work on this as my first bug, anyone available for mentoring?

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: start_recording.png

Hi Brad, thanks for wanting to work on this. 
Unfortunately (for you), it seems that this has been fixed (see the attachment). Dark theme has been revamped and I guess this had been taking care of. Maybe you'd be interested to work on Bug 1067999, which is a CSS bug too ? 

Helen can you confirm we can close this bug ?

Comment 5

[Brad Aytes [:eights]]

Hey Nicolas, thats quite alright; at least its fixed. No worries, the bug 1067999 will be fine. I'll add a comment on it and start looking into it. Thanks!

Comment 6

[Helen V. Holmes (:helenvholmes) (:✨)]

Yeah, I think we can close this out.

Brad, if you'd still like to pick up a bug, you can search using the [good first bug] whiteboard.