Add groups in Settings > Advanced

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: antlam, Assigned: Margaret, Mentored)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 48
All
Android
Points:
---

Firefox Tracking Flags

(firefox48 verified)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Like bug 1260930, I think we need a grouping of "Data usage" in our Advanced settings.

We can place this at the top of the list for now.

Data usage
---
Show images

Show web fonts
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Created attachment 8736829 [details]
settings_data_usage.png
Attachment #8736829 - Flags: feedback?(alam)
Created attachment 8736833 [details]
MozReview Request: Bug 1261137 - Add "Data usage" group in Settings > Advanced. r?ahunt

Review commit: https://reviewboard.mozilla.org/r/43573/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43573/
Attachment #8736833 - Flags: review?(ahunt)
(Reporter)

Comment 3

3 years ago
I don't think we should tuck this at the bottom of the list. But to put it at the top, we'll need to group and label the other items in this list too.

Sorry, but let's hold off on this for now until we can label the other sections. :)
Attachment #8736829 - Flags: feedback?(alam)
Attachment #8736833 - Flags: review?(ahunt)
ok
Assignee: s.kaspari → nobody
Mentor: s.kaspari
Status: ASSIGNED → NEW
(Reporter)

Comment 5

3 years ago
It looks like the whole "Advanced" page could benefit from some grouping. Let's repurpose this bug as such.

+------------------------------------+
|                                    |
|  Advanced                          |
|                                    |
+------------------------------------+
|                                    |
|  Auto update                       |
|                                    |
|  Restore tabs                      |
|                                    |
|  Character encoding                |
|                                    |
|                                    |
|  [Data saver]                      |
|                                    |
|  Show images                       |
|                                    |
|  Show web fonts                    |
|                                    |
|                                    |
|  [Media]                           |
|                                    |
|  Plugins                           |
|                                    |
|  Allow autoplay                    |
|                                    |
|                                    |
|  [Developer tools]                 |
|                                    |
|  Remote debugging via USB          |
|                                    |
|  Remote debugging via Wi-Fi        |
|                                    |
|                                    |
+------------------------------------+


To be clear, the groups are in square brackets above. 

Data saver

Media

Developer tools
(Reporter)

Updated

3 years ago
Summary: Add "Data usage" group in Settings > Advanced → Add groups in Settings > Advanced
(Assignee)

Updated

3 years ago
Assignee: nobody → margaret.leibovic
(Assignee)

Comment 6

3 years ago
Created attachment 8740658 [details]
MozReview Request: Bug 1261137 - Add groups in Settings > Advanced. r=sebastian

Review commit: https://reviewboard.mozilla.org/r/45859/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45859/
Attachment #8740658 - Flags: review?(s.kaspari)
(Assignee)

Updated

3 years ago
Attachment #8736833 - Attachment is obsolete: true
Comment on attachment 8740658 [details]
MozReview Request: Bug 1261137 - Add groups in Settings > Advanced. r=sebastian

https://reviewboard.mozilla.org/r/45859/#review42567

::: mobile/android/base/resources/xml/preferences_advanced.xml:74
(Diff revision 1)
> +    </PreferenceCategory>
> +
>  
>      <SwitchPreference android:key="devtools.remote.wifi.enabled"
>                        android:title="@string/pref_developer_remotedebugging_wifi" />
>  
>      <org.mozilla.gecko.preferences.AlignRightLinkPreference android:key="android.not_a_preference.remote_debugging.link"
>                                                              android:title="@string/pref_learn_more"
>                                                              android:persistent="false"
>                                                              url="https://developer.mozilla.org/docs/Tools/Remote_Debugging/Debugging_Firefox_for_Android_with_WebIDE" />
>  

The WiFi preferences is outside of the developer tools category.
Attachment #8740658 - Flags: review?(s.kaspari) → review+
(Assignee)

Comment 9

3 years ago
(In reply to Sebastian Kaspari (:sebastian) from comment #7)
> Comment on attachment 8740658 [details]
> MozReview Request: Bug 1261137 - Add groups in Settings > Advanced.
> r=sebastian
> 
> https://reviewboard.mozilla.org/r/45859/#review42567
> 
> ::: mobile/android/base/resources/xml/preferences_advanced.xml:74
> (Diff revision 1)
> > +    </PreferenceCategory>
> > +
> >  
> >      <SwitchPreference android:key="devtools.remote.wifi.enabled"
> >                        android:title="@string/pref_developer_remotedebugging_wifi" />
> >  
> >      <org.mozilla.gecko.preferences.AlignRightLinkPreference android:key="android.not_a_preference.remote_debugging.link"
> >                                                              android:title="@string/pref_learn_more"
> >                                                              android:persistent="false"
> >                                                              url="https://developer.mozilla.org/docs/Tools/Remote_Debugging/Debugging_Firefox_for_Android_with_WebIDE" />
> >  
> 
> The WiFi preferences is outside of the developer tools category.

Oops, good catch. I also failed to move the character encoding item to up higher. I fixed both issues before landing.

Comment 10

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/196a0e282b3e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Created attachment 8742220 [details]
Screenshot_2016-04-18-11-10-29.png

Verified as fixed using:
Device: Nexus 7 (Android 5.1)
Build: Firefox for Android 48.0a1 (2016-04-17)
status-firefox48: fixed → verified
You need to log in before you can comment on or make changes to this bug.