Closed Bug 1261144 Opened 4 years ago Closed 4 years ago

simplify AccCollector and EmbeddedObjCollector

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Details

Attachments

(17 files)

1.84 KB, patch
lsocks
: review+
Details | Diff | Splinter Review
2.01 KB, patch
lsocks
: review+
Details | Diff | Splinter Review
2.26 KB, patch
lsocks
: review+
Details | Diff | Splinter Review
2.19 KB, patch
lsocks
: review+
Details | Diff | Splinter Review
2.14 KB, patch
lsocks
: review+
Details | Diff | Splinter Review
2.09 KB, patch
lsocks
: review+
Details | Diff | Splinter Review
2.40 KB, patch
lsocks
: review+
Details | Diff | Splinter Review
2.94 KB, patch
lsocks
: review+
Details | Diff | Splinter Review
3.12 KB, patch
lsocks
: review+
Details | Diff | Splinter Review
2.88 KB, patch
lsocks
: review+
Details | Diff | Splinter Review
1.98 KB, patch
lsocks
: review+
Details | Diff | Splinter Review
1.25 KB, patch
lsocks
: review+
Details | Diff | Splinter Review
812 bytes, patch
Details | Diff | Splinter Review
789 bytes, patch
Details | Diff | Splinter Review
831 bytes, patch
lsocks
: review+
Details | Diff | Splinter Review
830 bytes, patch
lsocks
: review+
Details | Diff | Splinter Review
776 bytes, patch
lsocks
: review+
Details | Diff | Splinter Review
No description provided.
Attachment #8736848 - Flags: review?(lorien)
What's the reason to simplify now besides that AccCollector is only used for embedded objs right now? Do you think it's unlikely that we'd need collectors with other filters in the future?
(In reply to Lorien Hu (:lsocks) from comment #13)
> What's the reason to simplify now besides that AccCollector is only used for
> embedded objs right now? Do you think it's unlikely that we'd need
> collectors with other filters in the future?

Well, I'd say being unused functionality is good enough reason to simplify it, but it also lets us devirtualize some stuff, and more importantly I want to use it to collect ProxyAccessible* and its easier to do that without a bunch of useless crap around.
Attachment #8736839 - Flags: review?(lorien) → review+
Attachment #8736841 - Flags: review?(lorien) → review+
Attachment #8736842 - Flags: review?(lorien) → review+
Attachment #8736843 - Flags: review?(lorien) → review+
Attachment #8736844 - Flags: review?(lorien) → review+
Attachment #8736846 - Flags: review?(lorien) → review+
Attachment #8736847 - Flags: review?(lorien) → review+
Attachment #8736848 - Flags: review?(lorien) → review+
Attachment #8736850 - Flags: review?(lorien) → review+
Attachment #8736851 - Flags: review?(lorien) → review+
Attachment #8736853 - Flags: review?(lorien) → review+
Attachment #8736852 - Flags: review?(lorien) → review+
obvious bug is obvious :(
Attachment #8739157 - Flags: review?(lorien)
I forgot to do this initially
Attachment #8739160 - Flags: review?(lorien)
Attachment #8739157 - Flags: review?(lorien) → review+
Attachment #8739160 - Flags: review?(lorien) → review+
Attachment #8739161 - Flags: review?(lorien) → review+
EmbeddedObjCollector should include nsAccUtils.h
(In reply to Lorien Hu (:lsocks) from comment #20)
> EmbeddedObjCollector should include nsAccUtils.h

yeah, though now that I've been bitrotten it doesn't anymore
Assignee: nobody → tbsaunde+mozbugs
You need to log in before you can comment on or make changes to this bug.