1261144 - simplify AccCollector and EmbeddedObjCollector

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: move Count() from AccCollector to EmbeddedObjCollector

Comment 2

[Trevor Saunders (:tbsaunde)]

Attachment: move GetAccessibleAt to EmbeddedObjCollector

Comment 3

[Trevor Saunders (:tbsaunde)]

Attachment: devirtualize GetIndexAt() because the base class version is never called

Comment 4

[Trevor Saunders (:tbsaunde)]

Attachment: move EnsureNGetObject to EmbeddedObjCollector

Comment 5

[Trevor Saunders (:tbsaunde)]

Attachment: move EnsureNGetIndex() to EmbeddedObjCollector

Comment 6

[Trevor Saunders (:tbsaunde)]

Attachment: devirtualize AppendObject() because the base class impl is never called

Comment 7

[Trevor Saunders (:tbsaunde)]

Attachment: move the data members of AccCollector to EmbeddedObjCollector

Comment 8

[Trevor Saunders (:tbsaunde)]

Attachment: remove the AccCollector class

Comment 9

[Trevor Saunders (:tbsaunde)]

Attachment: rename AccCollector.{h,cpp} to EmbeddedObjCollector.{h,cpp}

Comment 10

[Trevor Saunders (:tbsaunde)]

Attachment: use filters::GetEmbeddedObject() directly in EmbeddedObjCollector

Comment 11

[Trevor Saunders (:tbsaunde)]

Attachment: call nsAccUtils::IsEmbeddedObject() directly from EmbeddedObjCollector

Comment 12

[Trevor Saunders (:tbsaunde)]

Attachment: remove filters::GetEmbeddedObj() because it is unused

Comment 13

[Lorien Hu (:lsocks)]

What's the reason to simplify now besides that AccCollector is only used for embedded objs right now? Do you think it's unlikely that we'd need collectors with other filters in the future?

Comment 14

[Trevor Saunders (:tbsaunde)]

(In reply to Lorien Hu (:lsocks) from comment #13)
> What's the reason to simplify now besides that AccCollector is only used for
> embedded objs right now? Do you think it's unlikely that we'd need
> collectors with other filters in the future?

Well, I'd say being unused functionality is good enough reason to simplify it, but it also lets us devirtualize some stuff, and more importantly I want to use it to collect ProxyAccessible* and its easier to do that without a bunch of useless crap around.

Comment 15

[Trevor Saunders (:tbsaunde)]

Attachment: devirtualize the dtor of EmbeddedObjCollector

Comment 16

[Trevor Saunders (:tbsaunde)]

Attachment: stop including Filters.h in EmbeddedObjCollector.h

Comment 17

[Trevor Saunders (:tbsaunde)]

Attachment: fix EmbeddedObjCollector ctor

obvious bug is obvious :(

Comment 18

[Trevor Saunders (:tbsaunde)]

Attachment: devirtualize the dtor of EmbeddedObjCollector

I forgot to do this initially

Comment 19

[Trevor Saunders (:tbsaunde)]

Attachment: stop including Filters.h in EmbeddedObjCollector.h

Comment 20

[Lorien Hu (:lsocks)]

EmbeddedObjCollector should include nsAccUtils.h

Comment 21

[Trevor Saunders (:tbsaunde)]

(In reply to Lorien Hu (:lsocks) from comment #20)
> EmbeddedObjCollector should include nsAccUtils.h

yeah, though now that I've been bitrotten it doesn't anymore

Comment 22

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/35e469fb244c
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7230134ac9b
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4f652ab9425
https://hg.mozilla.org/integration/mozilla-inbound/rev/2486e73b4a7f
https://hg.mozilla.org/integration/mozilla-inbound/rev/7be3111074b5
https://hg.mozilla.org/integration/mozilla-inbound/rev/04d186442c38
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f07e3f4ea98
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d674ccbdee1
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d94046fc040
https://hg.mozilla.org/integration/mozilla-inbound/rev/7068b471499f
https://hg.mozilla.org/integration/mozilla-inbound/rev/2571512a99dc
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd91240b139f
https://hg.mozilla.org/integration/mozilla-inbound/rev/daac3190ccfa
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c35ce0d49ad

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/35e469fb244c
https://hg.mozilla.org/mozilla-central/rev/f7230134ac9b
https://hg.mozilla.org/mozilla-central/rev/f4f652ab9425
https://hg.mozilla.org/mozilla-central/rev/2486e73b4a7f
https://hg.mozilla.org/mozilla-central/rev/7be3111074b5
https://hg.mozilla.org/mozilla-central/rev/04d186442c38
https://hg.mozilla.org/mozilla-central/rev/8f07e3f4ea98
https://hg.mozilla.org/mozilla-central/rev/9d674ccbdee1
https://hg.mozilla.org/mozilla-central/rev/4d94046fc040
https://hg.mozilla.org/mozilla-central/rev/7068b471499f
https://hg.mozilla.org/mozilla-central/rev/2571512a99dc
https://hg.mozilla.org/mozilla-central/rev/fd91240b139f
https://hg.mozilla.org/mozilla-central/rev/daac3190ccfa
https://hg.mozilla.org/mozilla-central/rev/9c35ce0d49ad