Closed Bug 1261172 Opened 4 years ago Closed 4 years ago
Start using Sync link in Dev Edition General Prefs links to deprecated Sync page
58 bytes, text/x-review-board-request
The “Start using Sync…” link in Dev Edition under General Prefs links to a deprecated Sync page about:accounts. It should instead link directly to this signin page. about:accounts?action=signin&entrypoint=menupanel We should give it a proper entry point name though. NIing RFkelly for that.
I don't think we have a terribly consistent naming scheme for these, but how about: about:accounts?action=signin&entrypoint=dev-edition-setup
SGTM and looks like a trivial change at https://dxr.mozilla.org/mozilla-central/source/browser/components/preferences/in-content/main.js#256
Component: Preferences → Sync
Review commit: https://reviewboard.mozilla.org/r/44251/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/44251/
Attachment #8738010 - Flags: review?(markh)
Assignee: rfkelly → tchiovoloni
Status: NEW → ASSIGNED
Comment on attachment 8738010 [details] MozReview Request: Bug 1261172 - update link to sync sign-in page shown in dev edition r?markh https://reviewboard.mozilla.org/r/44251/#review40915
Attachment #8738010 - Flags: review?(markh) → review+
You need to log in before you can comment on or make changes to this bug.