Closed
Bug 1261172
Opened 8 years ago
Closed 8 years ago
Start using Sync link in Dev Edition General Prefs links to deprecated Sync page
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: rfeeley, Assigned: tcsc)
Details
Attachments
(1 file)
The “Start using Sync…” link in Dev Edition under General Prefs links to a deprecated Sync page about:accounts. It should instead link directly to this signin page. about:accounts?action=signin&entrypoint=menupanel We should give it a proper entry point name though. NIing RFkelly for that.
Updated•8 years ago
|
Flags: needinfo?(rfkelly)
Comment 1•8 years ago
|
||
I don't think we have a terribly consistent naming scheme for these, but how about: about:accounts?action=signin&entrypoint=dev-edition-setup
Flags: needinfo?(rfkelly)
Comment 2•8 years ago
|
||
SGTM and looks like a trivial change at https://dxr.mozilla.org/mozilla-central/source/browser/components/preferences/in-content/main.js#256
Component: Preferences → Sync
Flags: firefox-backlog+
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/44251/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/44251/
Attachment #8738010 -
Flags: review?(markh)
Assignee | ||
Updated•8 years ago
|
Assignee: rfkelly → tchiovoloni
Status: NEW → ASSIGNED
Comment 4•8 years ago
|
||
Comment on attachment 8738010 [details] MozReview Request: Bug 1261172 - update link to sync sign-in page shown in dev edition r?markh https://reviewboard.mozilla.org/r/44251/#review40915
Attachment #8738010 -
Flags: review?(markh) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/451cde555145
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in
before you can comment on or make changes to this bug.
Description
•