1261176 - Simplify JS code for fetching performance data

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

Working on bug 1260110, I noticed a lot of confusing code around fetching performance signatures and data. This code kind of grew up organically when we were building perfherder, it's time to spend a few cycles and reduce our technical debt to ease maintenance.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1261176 > mozilla:master

Comment 2

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/af2c8635f852c5654233051a8f4cc040e70526a8
Bug 1261176 - Use getSeriesList for getting series in graphs view

https://github.com/mozilla/treeherder/commit/c27a21eb46019875f5872be6447b8fb021529884
Bug 1261176 - Simplify client-side getSeriesList API

Let's have it get the option collection map, if necessary, instead of
forcing the consumer to grab it every time.

https://github.com/mozilla/treeherder/commit/db513a216c4178e96cd02e9ef4cc1174ae5cd450
Bug 1261176 - More cleanup of the client-side PhSeries API

Remove some pointless abstractions, consolidate code, etc.

https://github.com/mozilla/treeherder/commit/ef2545dfff38b265841768da061e7cb83c4f3655
Bug 1261176 - Add and use a general function for getting performance data

This is better than the adhoc approach we have been using up to now.

Comment 3

[William Lachance (:wlach)]

Joel, the only likely candidate for reviewing this, is away, so I just went ahead and merged this after thorough testing.

Comment 5

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1261176-fix > mozilla:master

Comment 6

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/6b5aecb050c7d352900c9b0d15eeaa1c7a045592
Bug 1261176 - Fix a minor bug in clientside compare

https://github.com/mozilla/treeherder/commit/292ce46e43eadbc9e80f46ca3239c926f307371b
Merge pull request #1402 from wlach/1261176-fix

Bug 1261176 - Fix a minor bug in clientside compare