1261179 - Don't fallback to Desktop GL via WGL when ANGLE fails on Windows

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

On Windows, we currently try ANGLE first, and if that fails, we try to load native Desktop GL via WGL.

We should default to not allowing WGL.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: MozReview Request: Bug 1261179 - Don't fallback to WGL. - r?jrmuizel

From fbea8ca4bfe4a54ca571b427a915495e810cb21c Mon Sep 17 00:00:00 2001
---
 dom/canvas/WebGLContext.cpp | 3 +++
 1 file changed, 3 insertions(+)

Review commit: https://reviewboard.mozilla.org/r/43597/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43597/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8736922 [details]
MozReview Request: Bug 1261179 - Don't fallback to WGL. - r?jrmuizel

https://reviewboard.mozilla.org/r/43597/#review40171

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7725b6550258

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This apparently broke all android m(gl) tests like https://treeherder.mozilla.org/logviewer.html#?job_id=25208622&repo=mozilla-inbound

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c5208db609

Comment 5

[Kelsey Gilbert [:jgilbert]]

Attachment: MozReview Request: Only try ANGLE on Windows. r?jrmuizel

From a9b376586cb643417862401766cdf78653cc6f28 Mon Sep 17 00:00:00 2001
---
 dom/canvas/WebGLContext.cpp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Review commit: https://reviewboard.mozilla.org/r/44419/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44419/

Comment 6

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8736922 [details]
MozReview Request: Bug 1261179 - Don't fallback to WGL. - r?jrmuizel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43597/diff/1-2/

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8738290 [details]
MozReview Request: Only try ANGLE on Windows. r?jrmuizel

https://reviewboard.mozilla.org/r/44419/#review41141

Comment 8

[Milan Sreckovic [:milan] (needinfo for best results)]

Release Note Request

Not sure if we release note things like this.  We obviously had some number of users that were able to at least start WebGL on the unsupported systems, falling from ANGLE supported configurations to WGL.  Those will now not be able to use WebGL.  Based on the crash reports, the numbers are small, highest by percentage on Windows XP (running as high as 0.2% of all crashes), so those people "should be told".  Perhaps.

Comment 9

[Kelsey Gilbert [:jgilbert]]

Attachment: MozReview Request: Don't ever fall through. r?jrmuizel

From bd70851fb9a2e8645f1d279a7653e321dd303f4c Mon Sep 17 00:00:00 2001
---
 dom/canvas/WebGLContext.cpp | 84 ++++++++++++++++++---------------------------
 1 file changed, 34 insertions(+), 50 deletions(-)

Review commit: https://reviewboard.mozilla.org/r/45087/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45087/

Comment 10

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8736922 [details]
MozReview Request: Bug 1261179 - Don't fallback to WGL. - r?jrmuizel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43597/diff/2-3/

Comment 11

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8738290 [details]
MozReview Request: Only try ANGLE on Windows. r?jrmuizel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44419/diff/1-2/

Comment 12

[Kelsey Gilbert [:jgilbert]]

Try is happy now:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=830faa512bba

Note that this now removes *all* backend fallbacks. If you're using prefer-egl, and that fails, we won't fallback to GLX or whatever.

Comment 13

[Jeff Muizelaar [:jrmuizel]]

(In reply to Jeff Gilbert [:jgilbert] from comment #10)
> Comment on attachment 8736922 [details]
> MozReview Request: Bug 1261179 - Don't fallback to WGL. - r?jrmuizel
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/43597/diff/2-3/

Separating out the cosmetic changes from the functional change would make this easier to review.

Comment 14

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8739174 [details]
MozReview Request: Don't ever fall through. r?jrmuizel

https://reviewboard.mozilla.org/r/45087/#review43133

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b77af186da2

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1b77af186da2

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Not sure it was worth mentioning...