Closed
Bug 1261179
Opened 8 years ago
Closed 8 years ago
Don't fallback to Desktop GL via WGL when ANGLE fails on Windows
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: jgilbert, Assigned: jgilbert)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
On Windows, we currently try ANGLE first, and if that fails, we try to load native Desktop GL via WGL. We should default to not allowing WGL.
Assignee | ||
Comment 1•8 years ago
|
||
From fbea8ca4bfe4a54ca571b427a915495e810cb21c Mon Sep 17 00:00:00 2001 --- dom/canvas/WebGLContext.cpp | 3 +++ 1 file changed, 3 insertions(+) Review commit: https://reviewboard.mozilla.org/r/43597/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43597/
Attachment #8736922 -
Flags: review?(jmuizelaar)
Comment 2•8 years ago
|
||
Comment on attachment 8736922 [details] MozReview Request: Bug 1261179 - Don't fallback to WGL. - r?jrmuizel https://reviewboard.mozilla.org/r/43597/#review40171
Attachment #8736922 -
Flags: review?(jmuizelaar) → review+
This apparently broke all android m(gl) tests like https://treeherder.mozilla.org/logviewer.html#?job_id=25208622&repo=mozilla-inbound Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c5208db609
Flags: needinfo?(jgilbert)
Assignee | ||
Comment 5•8 years ago
|
||
From a9b376586cb643417862401766cdf78653cc6f28 Mon Sep 17 00:00:00 2001 --- dom/canvas/WebGLContext.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) Review commit: https://reviewboard.mozilla.org/r/44419/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/44419/
Attachment #8738290 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8736922 [details] MozReview Request: Bug 1261179 - Don't fallback to WGL. - r?jrmuizel Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43597/diff/1-2/
Comment 7•8 years ago
|
||
Comment on attachment 8738290 [details] MozReview Request: Only try ANGLE on Windows. r?jrmuizel https://reviewboard.mozilla.org/r/44419/#review41141
Attachment #8738290 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(jgilbert)
Release Note Request Not sure if we release note things like this. We obviously had some number of users that were able to at least start WebGL on the unsupported systems, falling from ANGLE supported configurations to WGL. Those will now not be able to use WebGL. Based on the crash reports, the numbers are small, highest by percentage on Windows XP (running as high as 0.2% of all crashes), so those people "should be told". Perhaps.
relnote-firefox:
--- → ?
Assignee | ||
Comment 9•8 years ago
|
||
From bd70851fb9a2e8645f1d279a7653e321dd303f4c Mon Sep 17 00:00:00 2001 --- dom/canvas/WebGLContext.cpp | 84 ++++++++++++++++++--------------------------- 1 file changed, 34 insertions(+), 50 deletions(-) Review commit: https://reviewboard.mozilla.org/r/45087/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/45087/
Attachment #8739174 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8736922 [details] MozReview Request: Bug 1261179 - Don't fallback to WGL. - r?jrmuizel Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43597/diff/2-3/
Assignee | ||
Comment 11•8 years ago
|
||
Comment on attachment 8738290 [details] MozReview Request: Only try ANGLE on Windows. r?jrmuizel Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44419/diff/1-2/
Assignee | ||
Comment 12•8 years ago
|
||
Try is happy now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=830faa512bba Note that this now removes *all* backend fallbacks. If you're using prefer-egl, and that fails, we won't fallback to GLX or whatever.
Comment 13•8 years ago
|
||
(In reply to Jeff Gilbert [:jgilbert] from comment #10) > Comment on attachment 8736922 [details] > MozReview Request: Bug 1261179 - Don't fallback to WGL. - r?jrmuizel > > Review request updated; see interdiff: > https://reviewboard.mozilla.org/r/43597/diff/2-3/ Separating out the cosmetic changes from the functional change would make this easier to review.
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(jmuizelaar)
Comment 14•8 years ago
|
||
Comment on attachment 8739174 [details] MozReview Request: Don't ever fall through. r?jrmuizel https://reviewboard.mozilla.org/r/45087/#review43133
Attachment #8739174 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(jmuizelaar)
Comment 16•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1b77af186da2
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•