Closed Bug 1261195 Opened 8 years ago Closed 8 years ago

test_selection_underline.html fails on Windows 10 in automation

Categories

(Core :: Layout, defect)

Unspecified
Windows 10
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

Details

Attachments

(1 file)

Windows 10 is available for opt-in on Try (albeit with a whopping one total
slave). I've been toying around with it to see where things stand and this
failure was one that popped up.

Looks like this just needs the same treatment Win8 got over in bug 1085529.
http://hg.mozilla.org/mozilla-central/diff/7a8948248cbd/layout/generic/test/test_selection_underline.html

https://treeherder.mozilla.org/logviewer.html#?job_id=18578932&repo=try
FWIW, Win8/Win10 are the only platforms in CI that have D2D enabled, which seems like a likely culprit here. Do we have a better way of detecting that rather than relying on hacky solutions like we've currently got?
I shamelessly stole IsD2DEnabled() from test_canvas.html. Appears to do the trick nicely.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d5c6a7ce764
Attachment #8737051 - Flags: review?(matt.woodrow)
Attachment #8737051 - Attachment is patch: true
Attachment #8737051 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/2ad120057ac1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.