Closed
Bug 1261231
Opened 8 years ago
Closed 8 years ago
Incorrect refcounting in imgLoader::GetInstance causes shutdown leak
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
Details
Attachments
(1 file)
The function assigns an already-addrefed raw pointer to a RefPtr, which addrefs it again, and leads to a shutdown leak if it's ever called.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43625/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43625/
Attachment #8736997 -
Flags: review?(seth)
Assignee | ||
Comment 2•8 years ago
|
||
Should I find someone else to review this? It's blocking us from landing notification tests.
Flags: needinfo?(seth)
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(seth)
Assignee | ||
Updated•8 years ago
|
Attachment #8736997 -
Flags: review?(seth) → review?(gkrizsanits)
Comment 3•8 years ago
|
||
Comment on attachment 8736997 [details] MozReview Request: Bug 1261231: Fix shutdown leak in imgLoader::GetInstance. r?seth https://reviewboard.mozilla.org/r/43625/#review44123 This looks great, thanks.
Attachment #8736997 -
Flags: review?(gkrizsanits) → review+
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/9774863180f92d75e7851f138bed71fe9828122a Bug 1261231: Fix shutdown leak in imgLoader::GetInstance. r=gabor
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9774863180f9
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•