Closed Bug 1261231 Opened 8 years ago Closed 8 years ago

Incorrect refcounting in imgLoader::GetInstance causes shutdown leak

Categories

(Core :: Graphics: ImageLib, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

Details

Attachments

(1 file)

The function assigns an already-addrefed raw pointer to a RefPtr, which addrefs it again, and leads to a shutdown leak if it's ever called.
Should I find someone else to review this? It's blocking us from landing notification tests.
Flags: needinfo?(seth)
Flags: needinfo?(seth)
Attachment #8736997 - Flags: review?(seth) → review?(gkrizsanits)
Comment on attachment 8736997 [details]
MozReview Request: Bug 1261231: Fix shutdown leak in imgLoader::GetInstance. r?seth

https://reviewboard.mozilla.org/r/43625/#review44123

This looks great, thanks.
Attachment #8736997 - Flags: review?(gkrizsanits) → review+
https://hg.mozilla.org/mozilla-central/rev/9774863180f9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.