Closed
Bug 1261233
Opened 5 years ago
Closed 4 years ago
Intermittent test_bug331215.xul | application timed out after 330 seconds with no output
Categories
(Toolkit :: General, defect, P3)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: KWierso, Assigned: mikedeboer)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•5 years ago
|
Summary: Intermittent test_bug331215.xul | application timed out after 330 seconds with no output | application crashed [@ mach_msg_trap + 0xa] → Intermittent test_bug331215.xul | application timed out after 330 seconds with no output
Comment hidden (Intermittent Failures Robot) |
Comment 8•4 years ago
|
||
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Comment hidden (Intermittent Failures Robot) |
Comment 10•4 years ago
|
||
Mike, this and bug 1259339 seem to be hitting again. Can you please take a look?
Flags: needinfo?(mdeboer)
See Also: → 1259339
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Flags: needinfo?(mdeboer)
Assignee | ||
Comment 20•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a954cefde175
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 23•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0f91b9fb28c
Comment hidden (mozreview-request) |
Comment 25•4 years ago
|
||
mozreview-review |
Comment on attachment 8835079 [details] Bug 1261233 - prevent test_bug331215.xul from intermittently timing out. https://reviewboard.mozilla.org/r/110796/#review112190 Looks good to me, thanks for making our tests better. Some suggestions below. :-) ::: toolkit/content/tests/chrome/bug331215_window.xul:51 (Diff revision 1) > > function* startTestWithBrowser(browserId) { > info("Starting test with browser '" + browserId + "'"); > gBrowser = document.getElementById(browserId); > gFindBar.browser = gBrowser; > - let promise = ContentTask.spawn(gBrowser, null, function* () { > + let promise = BrowserTestUtils.browserLoaded(gBrowser); I think you want gBrowser.selectedBrowser. Not sure if it actually works if you pass tabbrowser, but might as well be precise. :-) ::: toolkit/content/tests/chrome/bug331215_window.xul:66 (Diff revision 1) > .getControllerForCommand("cmd_moveTop") > .doCommand("cmd_moveTop"); > - yield enterStringIntoFindField("l"); > + yield promiseEnterStringIntoFindField("l"); > ok(gFindBar._findField.getAttribute("status") == "notfound", > "Findfield status attribute should have been 'notfound'" + > " after entering ltest"); Nit: can we fix the trailing ws here while we're here? ::: toolkit/content/tests/chrome/bug331215_window.xul:74 (Diff revision 1) > } > > - function* enterStringIntoFindField(aString) { > + function promiseEnterStringIntoFindField(aString) { > - for (let i = 0; i < aString.length; i++) { > - let event = document.createEvent("KeyboardEvent"); > - let promise = new Promise(resolve => { > + let promise = new Promise(resolve => { Nit: just use: ```js return new Promise(resolve => { ... }); ``` ::: toolkit/content/tests/chrome/bug331215_window.xul:86 (Diff revision 1) > - } > + } > - }; > + }; > - gFindBar.browser.finder.addResultListener(listener); > + gFindBar.browser.finder.addResultListener(listener); > - }); > + }); > + > + for (let i = 0; i < aString.length; i++) { Nit: trailing ws Also, you can just actually use a: ```js for (let c of aString) { ``` style loop (yeah! iterate over characters!) Also, can we use a new KeyEvent/KeyboardEvent() instead of using `createEvent` and would that allow us to just pass the string instead of the charCode? That'd be simpler. The constructor should definitely be simpler than the initKeyEvent method. :-)
Attachment #8835079 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 27•4 years ago
|
||
mozreview-review-reply |
Comment on attachment 8835079 [details] Bug 1261233 - prevent test_bug331215.xul from intermittently timing out. https://reviewboard.mozilla.org/r/110796/#review112190 > I think you want gBrowser.selectedBrowser. Not sure if it actually works if you pass tabbrowser, but might as well be precise. :-) I understand the confusement; gBrowser is used differently than in browser/ Fx code and mochitest-browser tests - here it's simply used as the holder of the current browser element. > Nit: trailing ws > > Also, you can just actually use a: > > ```js > for (let c of aString) { > ``` > style loop (yeah! iterate over characters!) > > Also, can we use a new KeyEvent/KeyboardEvent() instead of using `createEvent` and would that allow us to just pass the string instead of the charCode? That'd be simpler. The constructor should definitely be simpler than the initKeyEvent method. :-) Excellent review comments, thanks!
Comment 28•4 years ago
|
||
Pushed by mdeboer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f1fa60cbe6a prevent test_bug331215.xul from intermittently timing out. r=Gijs
Comment 29•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8f1fa60cbe6a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment hidden (Intermittent Failures Robot) |
Updated•4 years ago
|
status-firefox52:
--- → affected
status-firefox53:
--- → affected
Comment 31•4 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/b1aabc07a387
Flags: in-testsuite+
Comment 32•4 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/a537b707d7d2
Comment 33•4 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-esr52/rev/a537b707d7d2
status-firefox-esr52:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•