1261263 - Clean-up build system handling of C++11 and C99

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1261263 - Unsupport clang < 3.4. r?froydnj

In bug 1254861, we unsupported clang < 3.3, picking 3.3 essentially
because that's the smallest version we had on automation. Bug 1254854
changed that, and the smallest version on automation is now 3.5.

Now, the motivation to unsupport an old version of clang again is that
recent versions don't have the problem with __float128 used in libstdc++
headers (bug 654493). In fact, starting with clang 3.4, the hack we have
in place is not necessary.

So let's just drop support for clang 3.3 instead of keeping that hack
around longer.

As mentioned in bug 1254854, Ubuntu 12.04 LTS has clang 3.4 packages.

Review commit: https://reviewboard.mozilla.org/r/43701/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43701/

Comment 2

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1261263 - Remove test for libstdc++ headers conflict with clang 3.3. r?froydnj

Also remove the hack around it.

Review commit: https://reviewboard.mozilla.org/r/43703/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43703/

Comment 3

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1261263 - Switch from -std=gnu++0x to -std=gnu++11. r?froydnj

All the GCC and clang versions we support support the latter, so let's
use it.

Review commit: https://reviewboard.mozilla.org/r/43705/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43705/

Comment 4

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1261263 - Remove -fgnu89-inline. r?froydnj

It seems the reason why it was added back in bug 719659 is gone.

Review commit: https://reviewboard.mozilla.org/r/43707/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43707/

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8737065 [details]
MozReview Request: Bug 1261263 - Unsupport clang < 3.4. r?froydnj

https://reviewboard.mozilla.org/r/43701/#review40721

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8737066 [details]
MozReview Request: Bug 1261263 - Remove test for libstdc++ headers conflict with clang 3.3. r?froydnj

https://reviewboard.mozilla.org/r/43703/#review40723

Comment 7

[Nathan Froyd [:froydnj]]

Comment on attachment 8737067 [details]
MozReview Request: Bug 1261263 - Switch from -std=gnu++0x to -std=gnu++11. r?froydnj

https://reviewboard.mozilla.org/r/43705/#review40725

It looks like we need to update `js/src/js-config.in` too.  r=me with that.

Comment 8

[Nathan Froyd [:froydnj]]

Comment on attachment 8737068 [details]
MozReview Request: Bug 1261263 - Remove -fgnu89-inline. r?froydnj

https://reviewboard.mozilla.org/r/43707/#review40727

Yay!

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e5ae87fb396
https://hg.mozilla.org/integration/mozilla-inbound/rev/b66c04c0c8d5
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbddfbf778ec
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0daa17bdb2f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0e5ae87fb396
https://hg.mozilla.org/mozilla-central/rev/b66c04c0c8d5
https://hg.mozilla.org/mozilla-central/rev/fbddfbf778ec
https://hg.mozilla.org/mozilla-central/rev/c0daa17bdb2f