Clean-up build system handling of C++11 and C99

RESOLVED FIXED in Firefox 48

Status

defect
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla48
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(4 attachments)

No description provided.
Blocks: 1259382
Depends on: 719659
Summary: Clean-up build system handling of C++11 → Clean-up build system handling of C++11 and C99
In bug 1254861, we unsupported clang < 3.3, picking 3.3 essentially
because that's the smallest version we had on automation. Bug 1254854
changed that, and the smallest version on automation is now 3.5.

Now, the motivation to unsupport an old version of clang again is that
recent versions don't have the problem with __float128 used in libstdc++
headers (bug 654493). In fact, starting with clang 3.4, the hack we have
in place is not necessary.

So let's just drop support for clang 3.3 instead of keeping that hack
around longer.

As mentioned in bug 1254854, Ubuntu 12.04 LTS has clang 3.4 packages.

Review commit: https://reviewboard.mozilla.org/r/43701/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43701/
Attachment #8737065 - Flags: review?(nfroyd)
Attachment #8737066 - Flags: review?(nfroyd)
Attachment #8737067 - Flags: review?(nfroyd)
Attachment #8737068 - Flags: review?(nfroyd)
All the GCC and clang versions we support support the latter, so let's
use it.

Review commit: https://reviewboard.mozilla.org/r/43705/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43705/
Comment on attachment 8737065 [details]
MozReview Request: Bug 1261263 - Unsupport clang < 3.4. r?froydnj

https://reviewboard.mozilla.org/r/43701/#review40721
Attachment #8737065 - Flags: review?(nfroyd) → review+
Comment on attachment 8737066 [details]
MozReview Request: Bug 1261263 - Remove test for libstdc++ headers conflict with clang 3.3. r?froydnj

https://reviewboard.mozilla.org/r/43703/#review40723
Attachment #8737066 - Flags: review?(nfroyd) → review+
Comment on attachment 8737067 [details]
MozReview Request: Bug 1261263 - Switch from -std=gnu++0x to -std=gnu++11. r?froydnj

https://reviewboard.mozilla.org/r/43705/#review40725

It looks like we need to update `js/src/js-config.in` too.  r=me with that.
Attachment #8737067 - Flags: review?(nfroyd) → review+
Comment on attachment 8737068 [details]
MozReview Request: Bug 1261263 - Remove -fgnu89-inline. r?froydnj

https://reviewboard.mozilla.org/r/43707/#review40727

Yay!
Attachment #8737068 - Flags: review?(nfroyd) → review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.