Closed Bug 1261269 Opened 8 years ago Closed 8 years ago

All Desktop test suites running on the reftest harness are going to permafail when Gecko 47 merges to Beta due to nonlocal connections

Categories

(Testing :: Reftest, defect)

Product:
Testing
Component:
Reftest
Version:
Version 3
Platform:
Unspecified
All
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(firefox46 unaffected, firefox47- affected, firefox48- affected)

Status:
RESOLVED DUPLICATE of bug 1245092
Tracking Flags:
Tracking Status
firefox46 --- unaffected
firefox47 - affected
firefox48 - affected

People

(Reporter: RyanVM, Unassigned)

Details

[Tracking Requested - why for this release]: Mass reftest permafail when Gecko 47 merges to Beta.

ahal, this feels like more of the addon signing related issues we've been seeing. Any thoughts as to what might need fixing this time around?

https://treeherder.mozilla.org/logviewer.html#?job_id=18731466&repo=try

FATAL ERROR: Non-local network connections are disabled and a connection attempt to www.mozilla.org (104.16.40.2) was made.
Flags: needinfo?(ahalberstadt)
Ugh, I really wish that Non-local assert included the full url, not just the domain. Because www.mozilla.org really narrows it down /s.

All the work I did for addon signing landed on 46-48, so I don't think it's related to that. I'd guess it's some new pref or service that is set differently on the beta channel. I'll see if I can find anything suspicious.
Flags: needinfo?(ahalberstadt)
My suspicion is that it's something that landed on 48 and was uplifted to 47, because Trunk-as-Beta was looking pretty green by the end of the 47 cycle.
There's nothing obvious set here, but not in the nightly/aurora branding:
https://dxr.mozilla.org/mozilla-central/source/browser/branding/official/pref/firefox-branding.js

It's possible to get the full url from NSPR logs. I'll do a new try push that should upload them.
Assuming I didn't mess up, this should have the full url (it's based on your previous push):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=00aa8bee6f69

Look for "nspr-http.log" in the uploads, then Ctrl-F for "www.mozilla.com".
https://hg.mozilla.org/releases/mozilla-aurora/rev/2e72cafe79ff is making me nervous all of a sudden :)
Except that didn't burn Beta46 when it got uplifted there. I'll keep bisecting on Try.
Oh, I see what happened, it is this pref:
https://dxr.mozilla.org/mozilla-central/source/browser/branding/official/pref/firefox-branding.js#7

Sorry, this is my mistake. What happened was I landed 2e72cafe79ff on beta, and KWierso pinged me that it was busted. I was able to find and fix the problem quickly (as this is the same failure that you and I found with the similar mochitest patch). But in my rush to un-bust beta, I must have neglected to land the same fix back on aurora/central. For some reason I thought I did this, but checking now, that pref is definitely missing.

So to fix, this needs to be uplifted to aurora and central:
https://hg.mozilla.org/releases/mozilla-beta/rev/f902121e4d1b
This should be fixed on aurora tip now by bug 1245092. I also landed the fix on inbound.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.