1261271 - test_blocklist_regexp.js is going to permafail when Gecko 48 merges to Beta

Status: RESOLVED FIXED

(Cloud Services :: Firefox: Common, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Permafail when Gecko 48 merges to Beta.

https://treeherder.mozilla.org/logviewer.html#?job_id=18731308&repo=try

TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_blocklist_regexp.js | load_blocklist - [load_blocklist : 67] Kinto update should be enabled - false == true

Comment 1

[Mark Goodwin [:mgoodwin]]

The check to see if the kinto update is enabled is kind of redundant in the case where we're not updating anything via kinto. I'll make this check dependent on the value of security.onecrl.via.amo

Comment 2

[Mark Goodwin [:mgoodwin]]

Attachment: MozReview Request: Bug 1261271 - Prevent test_blocklist_regexp.js permafailing when 48 reaches beta. r?mossop

Review commit: https://reviewboard.mozilla.org/r/46197/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46197/

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8741100 [details]
MozReview Request: Bug 1261271 - Prevent test_blocklist_regexp.js permafailing when 48 reaches beta. r?mossop

https://reviewboard.mozilla.org/r/46197/#review42723

Comment 4

[Mark Goodwin [:mgoodwin]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=078566b8aa49

Comment 5

[Mark Goodwin [:mgoodwin]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc04a988f404ecd6de40583e2a6814f4e9db79c8
Bug 1261271 - Prevent test_blocklist_regexp.js permafailing when 48 reaches beta. r=mossop

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dc04a988f404