1261291 - Blank Hello first tour slideshow with addon version 1.2.2

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Bogdan Maris, Desktop QA]

[Affected versions]:
- Firefox 46 beta 7
Tinderbox build: http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-beta-win32/1459379981/

[Affected platforms]:
- Windows 7 64-bit
- Ubuntu 14.04 32-bit
- Mac OS X 10.10.5

[Steps to reproduce]:
1. Start Firefox
2. Click Hello icon
3. Click Browse this page with a friend

alternative steps if not using a new profile:
1. Start Firefox
2. Click Hello icon
3. Select Tour from gear settings icon

[Expected result]:
- Slideshow is displayed

[Actual result]:
- Blank slideshow is displayed

[Regression range]:
- This happens only on tinderbox 46 beta builds that have 1.2.2 version of Hello addon.

[Additional notes]:
- We can make the slideshow disappear only if you get lucky and click the area where X (close) should be displayed.

Comment 1

[Bogdan Maris, Desktop QA]

[Tracking Requested - why for this release]: It blocks Hello functionality

Comment 2

[Mark Banner (:standard8)]

Bug 1258865 initially got backed out of beta, then when it was relanded attachment 8733605 [details] [diff] [review] and attachment 8733606 [details] [diff] [review] were missed :-(

This is causing a missing string, which unfortunately breaks the display completely.

The unit test for this hasn't landed yet because of it causing intermittent issues (bug 1250107). I'm not sure if we would have caught this because of locale issues.

The other issue is that a missing en-US string makes us explode. For locales this shouldn't be an issue as they fallback to the en-US version of the string. However, if the en-US version ends up missing, then the code throws a js error. That might actually be the better thing to do from a developer perspective, although we should be failing gracefully. I'll get a bug filed to follow-up on doing something for this.

Comment 3

[Mark Banner (:standard8)]

The other thing: In future, I think I'll adjust how we do our patches, and make these imports one complete patch, and maybe provide a breakdown in comments if that helps release-drivers.

Comment 4

[Mark Banner (:standard8)]

The missing changes have landed in - see bug 1258865 comment 21

https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=191f5eb4cbd72590277296cdb90d355adb347d45 includes these.

Comment 5

[Bogdan Maris, Desktop QA]

We verified across platforms (Windows XP 32-bit, Mac OS X 10.8.5, Mac OS X 10.10.5, Windows 7 64-bit and Ubuntu 12.04 32-bit) that the slideshow is properly displayed using builds from comment 4.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

I don't think we need to track at this point since this is fixed and verified.