Closed Bug 1261311 Opened 5 years ago Closed 5 years ago
Fix storage inspector promise rejections
58 bytes, text/x-review-board-request
Now that bug Bug 1240804 has landed we have a lot of promise rejections in storage inspector tests so we need to change that.
Hide the errors for now. Review commit: https://reviewboard.mozilla.org/r/43795/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43795/
Comment on attachment 8737191 [details] MozReview Request: Bug 1261311 - Fix storage inspector promise rejections r=mratcliffe Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43795/diff/1-2/
Attachment #8737191 - Flags: review+
I think it really needs to be a "catch" handler for it to work?
https://hg.mozilla.org/integration/fx-team/rev/02e0770a169643107e35465f690c46f160fca670 Bug 1261311 - Fix storage inspector promise rejections r=mratcliffe
Setting leave-open since I am guessing "real" fixes will land later...?
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5) > Setting leave-open since I am guessing "real" fixes will land later...? Yes, totally.
Review commit: https://reviewboard.mozilla.org/r/43837/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43837/
Attachment #8737191 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/b73dfc2916f959611cc90ee906678a5bf11a0b5f Bug 1261311 - Fix storage inspector promise rejection syntax error r=mratcliffe
https://reviewboard.mozilla.org/r/43793/#review40397 Meant to use catch... just a workaround for the moment.
Attachment #8737242 - Flags: review?(mratcliffe)
Comment on attachment 8737242 [details] MozReview Request: Bug 1261311 - Fix storage inspector promise rejection syntax error r=mratcliffe https://reviewboard.mozilla.org/r/43837/#review40401
Attachment #8737242 - Flags: review?(mratcliffe) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1261785
You need to log in before you can comment on or make changes to this bug.