Fix storage inspector promise rejections

RESOLVED DUPLICATE of bug 1261785

Status

()

Firefox
Developer Tools: Storage Inspector
RESOLVED DUPLICATE of bug 1261785
2 years ago
2 years ago

People

(Reporter: miker, Assigned: miker)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

Now that bug Bug 1240804  has landed we have a lot of promise rejections in storage inspector tests so we need to change that.
Blocks: 1240804
Created attachment 8737191 [details]
MozReview Request: Bug 1261311 - Fix storage inspector promise rejections r=mratcliffe

Hide the errors for now.

Review commit: https://reviewboard.mozilla.org/r/43795/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43795/
Comment on attachment 8737191 [details]
MozReview Request: Bug 1261311 - Fix storage inspector promise rejections r=mratcliffe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43795/diff/1-2/
I think it really needs to be a "catch" handler for it to work?
Flags: needinfo?(mratcliffe)
Setting leave-open since I am guessing "real" fixes will land later...?
Keywords: leave-open
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5)
> Setting leave-open since I am guessing "real" fixes will land later...?

Yes, totally.
Flags: needinfo?(mratcliffe)
Created attachment 8737242 [details]
MozReview Request: Bug 1261311 - Fix storage inspector promise rejection syntax error r=mratcliffe

Review commit: https://reviewboard.mozilla.org/r/43837/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43837/
Attachment #8737191 - Attachment is obsolete: true
https://reviewboard.mozilla.org/r/43793/#review40397

Meant to use catch... just a workaround for the moment.
Attachment #8737242 - Flags: review?(mratcliffe)
Comment on attachment 8737242 [details]
MozReview Request: Bug 1261311 - Fix storage inspector promise rejection syntax error r=mratcliffe

https://reviewboard.mozilla.org/r/43837/#review40401
Attachment #8737242 - Flags: review?(mratcliffe) → review+
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Keywords: leave-open
Resolution: --- → DUPLICATE
Duplicate of bug: 1261785
You need to log in before you can comment on or make changes to this bug.