Closed
Bug 1261311
Opened 8 years ago
Closed 8 years ago
Fix storage inspector promise rejections
Categories
(DevTools :: Storage Inspector, defect)
DevTools
Storage Inspector
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1261785
People
(Reporter: miker, Assigned: miker)
References
Details
Attachments
(1 file, 1 obsolete file)
Now that bug Bug 1240804 has landed we have a lot of promise rejections in storage inspector tests so we need to change that.
Blocks: 1240804
Assignee | ||
Comment 1•8 years ago
|
||
Hide the errors for now. Review commit: https://reviewboard.mozilla.org/r/43795/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43795/
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8737191 [details] MozReview Request: Bug 1261311 - Fix storage inspector promise rejections r=mratcliffe Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43795/diff/1-2/
Assignee | ||
Updated•8 years ago
|
Attachment #8737191 -
Flags: review+
I think it really needs to be a "catch" handler for it to work?
Flags: needinfo?(mratcliffe)
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/02e0770a169643107e35465f690c46f160fca670 Bug 1261311 - Fix storage inspector promise rejections r=mratcliffe
Setting leave-open since I am guessing "real" fixes will land later...?
Keywords: leave-open
Assignee | ||
Comment 6•8 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5) > Setting leave-open since I am guessing "real" fixes will land later...? Yes, totally.
Flags: needinfo?(mratcliffe)
Assignee | ||
Comment 7•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43837/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43837/
Assignee | ||
Updated•8 years ago
|
Attachment #8737191 -
Attachment is obsolete: true
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/b73dfc2916f959611cc90ee906678a5bf11a0b5f Bug 1261311 - Fix storage inspector promise rejection syntax error r=mratcliffe
Assignee | ||
Comment 9•8 years ago
|
||
https://reviewboard.mozilla.org/r/43793/#review40397 Meant to use catch... just a workaround for the moment.
Assignee | ||
Updated•8 years ago
|
Attachment #8737242 -
Flags: review?(mratcliffe)
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8737242 [details] MozReview Request: Bug 1261311 - Fix storage inspector promise rejection syntax error r=mratcliffe https://reviewboard.mozilla.org/r/43837/#review40401
Attachment #8737242 -
Flags: review?(mratcliffe) → review+
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/02e0770a1696 https://hg.mozilla.org/mozilla-central/rev/b73dfc2916f9
Assignee | ||
Updated•8 years ago
|
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•