1261311 - Fix storage inspector promise rejections

Status: RESOLVED DUPLICATE of bug 1261785

(DevTools :: Storage Inspector, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Now that bug Bug 1240804  has landed we have a lot of promise rejections in storage inspector tests so we need to change that.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: MozReview Request: Bug 1261311 - Fix storage inspector promise rejections r=mratcliffe

Hide the errors for now.

Review commit: https://reviewboard.mozilla.org/r/43795/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43795/

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8737191 [details]
MozReview Request: Bug 1261311 - Fix storage inspector promise rejections r=mratcliffe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43795/diff/1-2/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I think it really needs to be a "catch" handler for it to work?

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://hg.mozilla.org/integration/fx-team/rev/02e0770a169643107e35465f690c46f160fca670
Bug 1261311 - Fix storage inspector promise rejections r=mratcliffe

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Setting leave-open since I am guessing "real" fixes will land later...?

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5)
> Setting leave-open since I am guessing "real" fixes will land later...?

Yes, totally.

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: MozReview Request: Bug 1261311 - Fix storage inspector promise rejection syntax error r=mratcliffe

Review commit: https://reviewboard.mozilla.org/r/43837/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43837/

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://hg.mozilla.org/integration/fx-team/rev/b73dfc2916f959611cc90ee906678a5bf11a0b5f
Bug 1261311 - Fix storage inspector promise rejection syntax error r=mratcliffe

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://reviewboard.mozilla.org/r/43793/#review40397

Meant to use catch... just a workaround for the moment.

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8737242 [details]
MozReview Request: Bug 1261311 - Fix storage inspector promise rejection syntax error r=mratcliffe

https://reviewboard.mozilla.org/r/43837/#review40401

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/02e0770a1696
https://hg.mozilla.org/mozilla-central/rev/b73dfc2916f9